api: add OOB BackendUtilization - #9400
Conversation
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0e29a4678
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9400 +/- ##
==========================================
+ Coverage 75.67% 75.68% +0.01%
==========================================
Files 254 254
Lines 41946 42110 +164
==========================================
+ Hits 31744 31873 +129
- Misses 8071 8092 +21
- Partials 2131 2145 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5923722feb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/retest |
| // +kubebuilder:validation:Maximum=65535 | ||
| // +optional | ||
| // +notImplementedHide | ||
| Port *uint32 `json:"port,omitempty"` |
There was a problem hiding this comment.
Should use gwapiv1.PortNumber
There was a problem hiding this comment.
@zhaohuabing I ended up reverting this back to *int32. We only use it in one other place currently vs int32 for 8 other port fields and it breaks the kubebuilder bounds setup.
There was a problem hiding this comment.
I'm going to merge this but will ping you on the implementation PR in case you'd still prefer to use PortNumber
|
/retest |
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaa35b4427
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34ee3ebcbf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e474be666f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
LGTM! |
What this PR does / why we need it:
Adds API fields to support ORCA Out-of-Band reporting
Which issue(s) this PR fixes:
xRef #9401