feat: support listenerset policy attach in backend traffic policy - #9419
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c88a804 to
148b54d
Compare
kkk777-7
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9419 +/- ##
==========================================
+ Coverage 75.73% 75.76% +0.02%
==========================================
Files 254 254
Lines 42110 42316 +206
==========================================
+ Hits 31892 32060 +168
- Misses 8073 8100 +27
- Partials 2145 2156 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c079decd74
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| parentRef.SectionName, | ||
| listenerSetNN, |
There was a problem hiding this comment.
When a Route parentRef targets a ListenerSet without sectionName (valid and used to attach to every compatible ListenerSet listener), this call sets listenerSetNN but still passes parentRef.SectionName, which is nil. LookupBTPRoutingType only checks listenerSetListenerLevel when a listener name is present, so a BackendTrafficPolicy targeting one ListenerSet section is ignored for these routes and they fall back to the ListenerSet/Gateway routingType instead of the listener-specific policy.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch, I think this issue existed before this PR.
the underlying limitation is the same as the existing Gateway all-listener parentRef behavior: processDestination only has parentRef.SectionName, so section-specific RoutingType is not resolved when the Route parentRef omits sectionName.
we may need to refactor processDestination to contain listener information.
This change is big, so if we fix this issue I prefer to handle this in follow-up PR.
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
c079dec to
9e5019d
Compare
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd0fcb971a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…voyproxy#9419) * feat: backend traffic policy listenerset attach Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add release note Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update docs Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix e2e testfile Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update latest code Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
4 participants
What this PR does / why we need it:
follow-up #9270
Support policy attachment for ListenerSet.
This PR includes:
currently, don't support mergeType for ListenerSet. only support for xRoute.
Which issue(s) this PR fixes:
Fixes #8092