feat: envoy extension policy listenerset attach - #9425
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58c9a0d6c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9425 +/- ##
==========================================
+ Coverage 75.65% 75.68% +0.02%
==========================================
Files 253 253
Lines 41879 42015 +136
==========================================
+ Hits 31684 31798 +114
- Misses 8064 8080 +16
- Partials 2131 2137 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
one naive question: the EEP should located in the same namespace with ListenerSet, is that right? |
|
hey any way we can perform additional translation only if len(listenerSets) > 0 ? |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Hi, I've updated by 4a06573. If looks good, I'll apply other policies in follow-up PR. |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
/retest |
* feat: envoy extension policy listenerset attach Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add release note Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix lint Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * perf: skip ls translation Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update latest code Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
What this PR does / why we need it:
follow-up #9270
Support policy attachment for ListenerSet.
This PR includes:
Which issue(s) this PR fixes:
Fixes #8092