feat: support SDS listener certificates#9529
Draft
hooiv wants to merge 3 commits into
Draft
Conversation
Signed-off-by: hooiv <125276621+hooiv@users.noreply.github>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: hooiv <125276621+hooiv@users.noreply.github>
Signed-off-by: ADITYA CHAUHAN <125276621+hooiv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Feature.
What does this PR do?
Adds support for using Envoy Gateway's existing
sds-refSecret type for Gateway listenercertificateRefs.Listener validation now accepts and validates SDS references, translates them into external SDS certificate configurations, and registers SDS endpoints as clusters for HTTP and TCP listeners.
Testing
git diff --checkpassed.go test ./internal/gatewayapi -count=1passes.TestIRTLSConfigsForSDSListenerCertificateTestProcessSDSClustersIncludesListenerCertificatesgo test ./internal/xds/translator -run '^TestTranslateXds/jwt-allow-missing-or-failed$' -count=1passes after updating the stale DNS cluster golden output for the current Envoy dependency.embed.FSpath issues are avoided by running the tests from Linux/WSL.Checklist
Fixes #9009