docs: add without-LoadBalancer testing instructions to traffic pages - #9573
docs: add without-LoadBalancer testing instructions to traffic pages#9573kkukadia wants to merge 2 commits into
Conversation
HTTP Routing, GRPC Routing, HTTP Timeouts, HTTP Redirects, HTTP URL Rewrite, and TCP Routing only showed how to test through an external LoadBalancer address, leaving clusters without one (e.g. kind) with no way to follow along. Adds a port-forward alternative for the pages with their own Gateway (HTTP Routing, GRPC Routing, TCP Routing), and points the pages that reuse the default eg Gateway (HTTP Redirects, HTTP URL Rewrite, HTTP Timeouts) at the GATEWAY_HOST already set up in Quickstart, matching the pattern used elsewhere in the docs. Signed-off-by: k1chik <kkukdia@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fd7d54774
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Ensure the `GATEWAY_HOST` environment variable from the [Quickstart](../../quickstart) is set. If not, follow the | ||
| Quickstart instructions to set the variable. | ||
|
|
||
| ```shell | ||
| export GATEWAY_HOST=$(kubectl get gateway/eg -o jsonpath='{.status.addresses[0].value}') | ||
| echo $GATEWAY_HOST |
There was a problem hiding this comment.
For clusters without LoadBalancer support—the environment this docs change is meant to unblock—the Quickstart does not export GATEWAY_HOST; it only starts a port-forward and curls localhost:8888. After following these new lines, echo $GATEWAY_HOST remains blank and the curl below expands to an unusable http:///get URL (the same pattern was added to URL Rewrite and Timeouts), so the eg-based traffic tasks still cannot be followed on kind-like clusters. Please include the port-forward plus GATEWAY_HOST=localhost:8888 setup here or make Quickstart export it.
Useful? React with 👍 / 👎.
The without-LoadBalancer tab port-forwarded and curled localhost:8888 directly but never exported GATEWAY_HOST, so pages that tell readers to reuse the variable from Quickstart (HTTP Redirects, HTTP URL Rewrite, HTTP Timeouts) ended up with it unset on kind-like clusters. Signed-off-by: k1chik <kkukdia@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d07d6482b4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ``` | ||
|
|
||
| ```shell | ||
| export GATEWAY_HOST=localhost:8888 |
There was a problem hiding this comment.
When users choose the new Without LoadBalancer path, this shared GATEWAY_HOST now includes a port, but several task pages that tell users to reuse the Quickstart variable still treat it as a bare address. For example, site/content/en/latest/tasks/security/jwt-authentication.md appends :80, producing localhost:8888:80, and site/content/en/latest/tasks/traffic/http-redirect.md passes it to curl --resolve, whose documented form is <[+]host:port:addr[,addr]...> and rejects localhost:8888 as the address. Please keep GATEWAY_HOST host-only and introduce a separate URL/port variable, or update the downstream consumers before exporting a port here.
Useful? React with 👍 / 👎.
2 participants
What this PR does / why we need it:
HTTP Routing, GRPC Routing, HTTP Timeouts, HTTP Redirects, HTTP URL Rewrite, and TCP Routing only showed how to test through an external LoadBalancer address, so clusters without one (e.g. kind) had no way to follow along.
Adds a port-forward alternative for the pages with their own Gateway (HTTP Routing, GRPC Routing, TCP Routing), and points the pages that reuse the default
egGateway (HTTP Redirects, HTTP URL Rewrite, HTTP Timeouts) at theGATEWAY_HOSTalready set up in Quickstart - same pattern used in the docs elsewhere (e.g. External Processing, Wasm Extensions).Which issue(s) this PR fixes:
Part of #5799 (traffic-routing batch)
Release Notes: No