-
Notifications
You must be signed in to change notification settings - Fork 828
docs: add without-LoadBalancer testing instructions to traffic pages #9573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,10 +75,11 @@ The HTTPRoute status should indicate that it has been accepted and is bound to t | |
| kubectl get httproute/http-to-https-filter-redirect -o yaml | ||
| ``` | ||
|
|
||
| Get the Gateway's address: | ||
| Ensure the `GATEWAY_HOST` environment variable from the [Quickstart](../../quickstart) is set. If not, follow the | ||
| Quickstart instructions to set the variable. | ||
|
|
||
| ```shell | ||
| export GATEWAY_HOST=$(kubectl get gateway/eg -o jsonpath='{.status.addresses[0].value}') | ||
| echo $GATEWAY_HOST | ||
|
Comment on lines
+78
to
+82
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For clusters without LoadBalancer support—the environment this docs change is meant to unblock—the Quickstart does not export Useful? React with 👍 / 👎. |
||
| ``` | ||
|
|
||
| Querying `redirect.example/get` should result in a `301` response from the example Gateway and redirecting to the | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When users choose the new Without LoadBalancer path, this shared
GATEWAY_HOSTnow includes a port, but several task pages that tell users to reuse the Quickstart variable still treat it as a bare address. For example,site/content/en/latest/tasks/security/jwt-authentication.mdappends:80, producinglocalhost:8888:80, andsite/content/en/latest/tasks/traffic/http-redirect.mdpasses it tocurl --resolve, whose documented form is<[+]host:port:addr[,addr]...>and rejectslocalhost:8888as the address. Please keepGATEWAY_HOSThost-only and introduce a separate URL/port variable, or update the downstream consumers before exporting a port here.Useful? React with 👍 / 👎.