Skip to content

fix: eliminate port race in setupFakeEnvoyStats test helper #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Jul 26, 2026
Merged

fix: eliminate port race in setupFakeEnvoyStats test helper #9580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/cmd/envoy/shutdown_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ import (

// setupFakeEnvoyStats set up an HTTP server return content
func setupFakeEnvoyStats(t *testing.T, content string) *http.Server {
// Reuse the bound listener instead of closing and re-binding the port.
l, err := net.Listen("tcp", ":0") //nolint: gosec
require.NoError(t, err)
require.NoError(t, l.Close())
mux := http.NewServeMux()
mux.HandleFunc("/", func(writer http.ResponseWriter, _ *http.Request) {
writer.Header().Set("Content-Type", "application/json")
Expand All @@ -39,7 +39,7 @@ func setupFakeEnvoyStats(t *testing.T, content string) *http.Server {
}
t.Logf("start to listen at %s ", addr)
go func() {
if err := s.ListenAndServe(); err != nil {
if err := s.Serve(l); err != nil {
fmt.Println("fail to listen: ", err)
}
}()
Expand Down
Loading