feat: Implement BackendUtilization LB OutOfBand reporting - #9593
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| github.com/envoyproxy/go-control-plane v0.14.1-0.20260728043526-94c89e8656f4 | ||
| github.com/envoyproxy/go-control-plane/contrib v1.36.1-0.20260728043526-94c89e8656f4 | ||
| github.com/envoyproxy/go-control-plane/envoy v1.37.1-0.20260728043526-94c89e8656f4 | ||
| github.com/envoyproxy/go-control-plane/ratelimit v0.1.1-0.20260728043526-94c89e8656f4 |
There was a problem hiding this comment.
Bump was needed to include the OrcaOobReportingConfig API field
19677c5 to
d90b0c8
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9593 +/- ##
==========================================
- Coverage 75.70% 75.68% -0.03%
==========================================
Files 254 254
Lines 42110 42131 +21
==========================================
+ Hits 31880 31885 +5
- Misses 8085 8096 +11
- Partials 2145 2150 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
d90b0c8 to
17af668
Compare
| // +kubebuilder:validation:Maximum=65535 | ||
| // +optional | ||
| // +notImplementedHide | ||
| Port *int32 `json:"port,omitempty"` |
There was a problem hiding this comment.
CC @zhaohuabing #9400 (comment)
@zhaohuabing I ended up reverting this back to *int32. We only use it in one other place currently vs int32 for 8 other port fields and it breaks the kubebuilder bounds setup.
Let's continue here on whether to use PortNumber instead.
What this PR does / why we need it:
Implementation for #9400 plus docs and e2e
Which issue(s) this PR fixes:
Fixes #9401