fix: repair broken composite literal in ratelimit TestDeployment - #9617
Closed
zhaohuabing wants to merge 1 commit into
Closed
fix: repair broken composite literal in ratelimit TestDeployment#9617zhaohuabing wants to merge 1 commit into
zhaohuabing wants to merge 1 commit into
Conversation
The rate limit test package fails to compile:
resource_provider_test.go:833:5: missing ',' before newline in composite literal
PR envoyproxy#9027 moved the rate limit fields into the embedded
EnvoyGatewayKubernetesInfrastructureConfiguration struct. Two of the
three call sites in this file were updated correctly, but the one in
TestDeployment added the opening brace without the matching closing
brace, most likely a bad conflict resolution against envoyproxy#9594, which had
just added RateLimitHpa to the same literal.
Close the inner literal and fix the indentation.
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9617 +/- ##
==========================================
+ Coverage 75.75% 75.83% +0.08%
==========================================
Files 254 258 +4
Lines 42322 42795 +473
==========================================
+ Hits 32059 32455 +396
- Misses 8107 8165 +58
- Partials 2156 2175 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: https://github.com/envoyproxy/gateway/actions/runs/30514179867/job/90780286454