Skip to content

follow up listenerset policy attachment - #9621

Merged
zirain merged 3 commits into
envoyproxy:mainfrom
kkk777-7:follow-up-ls-attachment
Aug 2, 2026
Merged

follow up listenerset policy attachment#9621
zirain merged 3 commits into
envoyproxy:mainfrom
kkk777-7:follow-up-ls-attachment

Conversation

@kkk777-7

@kkk777-7 kkk777-7 commented Jul 30, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Follow up for supporting ListenerSet policy attachment.

Which issue(s) this PR fixes:

Fixes #9607


PR Checklist

  • Authorship & ownership: Coding agents / AI assistants are welcome, but I have reviewed every change, understand how and why it works, can explain and maintain it, and take full responsibility for this PR. I have not submitted generated output I do not understand.
  • DCO: All commits are signed off (git commit -s). See DCO: Sign your work.
  • API agreed first: If this PR contains API changes (changes under /api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.
  • Required checks pass: make generate gen-check, make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, but gen-check, lint, and coverage MUST pass.)
  • Tests added/updated: New/changed code is covered by appropriate tests. N/A if this PR does not contain code changes.
  • Docs: User-facing changes update the docs, either in this PR or a follow-up PR. N/A if this PR does not contain user-facing changes.
  • Release notes: For any non-trivial change, added a release-note fragment under release-notes/current/<section>/<pr-number>-<slug>.md (see release-notes/current/README.md for sections and naming). N/A if this PR does not contain non-trivial changes.
  • Generated files committed: Ran make gen-check and committed the result if API/helm charts/modules changed.
  • Scope & compatibility: The PR is reasonably scoped (no unrelated changes) and preserves backward compatibility, or any breaking change is called out above and documented in release-notes/current/breaking_changes/.
  • Codex review: Requested a Codex review and addressed all of its comments.
  • Copilot review: Requested a Copilot review and addressed all of its comments.

kkk777-7 added 2 commits July 31, 2026 01:12
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
kkk777-7 requested a review from a team as a code owner July 30, 2026 16:21
@netlify

netlify Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 0b57de8
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a6bee2070ea540008ded6bf
😎 Deploy Preview https://deploy-preview-9621--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.75758% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.04%. Comparing base (b710dd4) to head (0b57de8).

Files with missing lines Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 77.14% 6 Missing and 2 partials ⚠️
internal/gatewayapi/securitypolicy.go 74.19% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9621   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files         259      259           
  Lines       43275    43258   -17     
=======================================
- Hits        32907    32896   -11     
+ Misses       8178     8173    -5     
+ Partials     2190     2189    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkk777-7

Copy link
Copy Markdown
Member Author

@codex review

@kkk777-7 kkk777-7 added this to the v1.9.0-rc.1 Release milestone Jul 30, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 6e8cf34353

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jukie
jukie previously approved these changes Jul 30, 2026

@jukie jukie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jukie

jukie commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/retest

@jukie
jukie requested review from a team July 30, 2026 18:10
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@jukie
jukie requested review from a team July 31, 2026 19:17
@zirain
zirain merged commit 8dcac65 into envoyproxy:main Aug 2, 2026
65 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

follow-up of listenerset policy attachment

3 participants