build(deps): add exptostd, govet, thelper, tparallel, usestdlibvars, and usetesting linters (#1410)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Author: mmorel-35

.golangci.yml

@@ -18,9 +18,11 @@ linters:
     - bodyclose
     - contextcheck
     - errorlint
+    - exptostd
     - gocritic
     - godot
     - gosec
+    - govet
     - misspell
     - modernize
     - noctx
@@ -29,8 +31,12 @@ linters:
     - revive
     - staticcheck
     - testifylint
+    - thelper
+    - tparallel
     - unconvert
     - unparam
+    - usestdlibvars
+    - usetesting
     - whitespace
   exclusions:
     generated: lax

pkg/cache/v3/simple_test.go

@@ -326,6 +326,7 @@ func TestSnapshotCacheWatch(t *testing.T) {
 }
 
 func TestConcurrentSetWatch(t *testing.T) {
+	t.Parallel()
 	c := cache.NewSnapshotCache(false, group{}, log.NewTestLogger(t))
 	for i := range 50 {
 		t.Run(fmt.Sprintf("worker%d", i), func(t *testing.T) {

pkg/log/test.go

@@ -8,8 +8,9 @@ type testLogger struct {
 
 var _ Logger = testLogger{}
 
-func NewTestLogger(t testing.TB) Logger {
-	return testLogger{t}
+func NewTestLogger(tb testing.TB) Logger {
+	tb.Helper()
+	return testLogger{tb}
 }
 
 // Debugf logs a message at level debug on the test logger.

pkg/server/v3/delta_test.go

@@ -149,6 +149,7 @@ func (stream *mockDeltaStream) Recv() (*discovery.DeltaDiscoveryRequest, error)
 }
 
 func makeMockDeltaStream(t *testing.T) *mockDeltaStream {
+	t.Helper()
 	ctx, cancel := context.WithCancel(context.Background())
 	return &mockDeltaStream{
 		t:      t,

pkg/server/v3/server_test.go

@@ -135,6 +135,7 @@ func (stream *mockStream) Recv() (*discovery.DiscoveryRequest, error) {
 }
 
 func makeMockStream(t *testing.T) *mockStream {
+	t.Helper()
 	return &mockStream{
 		t:    t,
 		ctx:  context.Background(),

pkg/test/main/main.go

@@ -339,7 +339,7 @@ func callEcho() (int, int) {
 		if err != nil {
 			return nil, err
 		}
-		return client.Do(req)
+		return client.Do(req) //nolint:gosec
 	}
 
 	// spawn requests

pkg/test/server.go

@@ -129,7 +129,7 @@ func (h *HTTPGateway) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
 		return
 	}
 
-	if _, err = resp.Write(bytes); err != nil && h.Log != nil {
+	if _, err = resp.Write(bytes); err != nil && h.Log != nil { //nolint:gosec
 		h.Log.Errorf("gateway error: %v", err)
 	}
 }