Envoy incremental check workflow#1390
Closed
ebyerly wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Elizabeth Byerly <ebyerly@google.com>
fd226c9 to
bca107b
Compare
Contributor
Author
|
@phlax - added you as a reviewer because I see you've been digging into how Nighthawk manages its automation. I didn't want to spend more than a few hours poking at this first draft of a Github Action without pulling in someone with more familiarity for feedback to make sure I'm not wandering down an obviously terrible path. Feel encouraged to bounce this back if you have no cycles! |
Signed-off-by: Elizabeth Byerly <ebyerly@google.com>
3a0281f to
d06df0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-envoy-commits.yml introduces a new Github Actions workflow. It runs every N hours.
It checks whether an Envoy commit after the current Nighthawk Bazel dependency requires a non-trivial merge. It does this by: looking for modifications to shared files, running the CI test process at the latest Envoy commit, and using
git bisectif the latest Envoy commit introduces a test break.It manages creating Github issues tracking Envoy commits that will require a non-trivial merge. It closes those issues once obsolete the Nighthawk Bazel dependency commit is a descendant of the issue commit.
The goal is to automate what is currently a manual bisection process during the weekly merge. The first extension would be to include managing a PR to increment Nighthawk's Bazel dependency to the latest possible trivial merge. The second extension would be to use an LLM to attempt to manage non-trivial merges.