tidy: use hermetic toolchain headers (#3969)

mathetake · web-flow · commit 7a9a8cc7b4c5 · 2026-04-03T15:15:05.000Z
Signed-off-by: Takeshi Yoneda &lt;tyoneda@netflix.com&gt;
diff --git a/bazel/format/clang_tidy/clang_tidy.bzl b/bazel/format/clang_tidy/clang_tidy.bzl
@@ -113,7 +113,7 @@ def _safe_flags(flags):
         "-fno-canonical-system-headers",
         "-fstack-usage",
     ]
-    return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot")]
+    return [flag for flag in flags if flag not in unsupported_flags]
 
 def _clang_tidy_aspect_impl(target, ctx):
     # if not a C/C++ target, we are not interested

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ def _safe_flags(flags):`
`113`	`113`	`"-fno-canonical-system-headers",`
`114`	`114`	`"-fstack-usage",`
`115`	`115`	`]`
`116`		`- return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot")]`
	`116`	`+ return [flag for flag in flags if flag not in unsupported_flags]`
`117`	`117`
`118`	`118`	`def _clang_tidy_aspect_impl(target, ctx):`
`119`	`119`	`# if not a C/C++ target, we are not interested`