Conversation
Under the main=tags / dev=active model, build.yml only triggering on main meant PRs into dev got zero CI and bugs surfaced only at the dev->main release PR. Adding dev to the push/pull_request branch filters runs the same matrix (Node 22.x/24.x + bun unit tests) on every dev contribution.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Build & Test workflow so CI runs for the new dev branch in addition to main, ensuring feature work is validated before the dev→main release PR.
Changes:
- Extend
pushtrigger branch filters to includedev - Extend
pull_requesttrigger branch filters to includedev
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
domiscd
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR under the new branching model (
main= tags/stable,dev= active work).What: adds
devtobuild.yml'spushandpull_requestbranch filters.Why:
build.ymlonly triggered onmain, so PRs intodevgot no CI — bugs would only surface at thedev→mainrelease PR, defeating the point of CI-gatingmain. Now the Node 22.x/24.x build +bun test tests/unitmatrix runs on everydevpush/PR too.Also serves as the end-to-end validation of the new
mainbranch protection (PR required,build (22.x)+build (24.x)required, 1 approval, no force-push).