#8186 - Reject monomer group template with empty groupClass

Author: mariam-khutuashvili

packages/ketcher-core/__tests__/application/editor/Editor.test.ts

@@ -11,6 +11,7 @@ import {
   KetcherLogger,
   MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH,
   MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH_ERROR_MESSAGE,
+  MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE,
 } from 'utilities';
 
 describe('CoreEditor', () => {
@@ -597,6 +598,72 @@ describe('CoreEditor', () => {
         initialTemplatesCount + 1,
       );
     });
+
+    it('should reject monomer group template with empty class', () => {
+      const presetWithEmptyClass = {
+        root: {
+          templates: [
+            {
+              $ref: 'monomerGroupTemplate-emptyClass',
+            },
+          ],
+        },
+        'monomerGroupTemplate-emptyClass': {
+          type: 'monomerGroupTemplate',
+          id: '',
+          name: 'TestPresetEmptyClass',
+          class: '',
+          templates: [],
+          connections: [],
+        },
+      };
+
+      const initialTemplatesCount =
+        editor.monomersLibraryParsedJson?.root.templates.length ?? 0;
+      editor.updateMonomersLibrary(JSON.stringify(presetWithEmptyClass));
+
+      expect(errorSpy).toHaveBeenCalledWith(
+        expect.stringContaining(
+          MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE,
+        ),
+      );
+      expect(editor.monomersLibraryParsedJson?.root.templates.length).toBe(
+        initialTemplatesCount,
+      );
+    });
+
+    it('should reject monomer group template with whitespace-only class', () => {
+      const presetWithWhitespaceClass = {
+        root: {
+          templates: [
+            {
+              $ref: 'monomerGroupTemplate-whitespaceClass',
+            },
+          ],
+        },
+        'monomerGroupTemplate-whitespaceClass': {
+          type: 'monomerGroupTemplate',
+          id: '',
+          name: 'TestPresetWhitespaceClass',
+          class: '   ',
+          templates: [],
+          connections: [],
+        },
+      };
+
+      const initialTemplatesCount =
+        editor.monomersLibraryParsedJson?.root.templates.length ?? 0;
+      editor.updateMonomersLibrary(JSON.stringify(presetWithWhitespaceClass));
+
+      expect(errorSpy).toHaveBeenCalledWith(
+        expect.stringContaining(
+          MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE,
+        ),
+      );
+      expect(editor.monomersLibraryParsedJson?.root.templates.length).toBe(
+        initialTemplatesCount,
+      );
+    });
   });
 
   describe('window blur handling', () => {

packages/ketcher-core/src/application/editor/Editor.ts

@@ -80,6 +80,7 @@ import {
   IDT_ALIAS_LENGTH_ERROR_MESSAGE,
   MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH,
   MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH_ERROR_MESSAGE,
+  MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE,
   isValidBilnAlias,
   isValidHelmAlias,
   isValidIdtAlias,
@@ -604,6 +605,19 @@ export class CoreEditor {
         return;
       }
 
+      // Only a present-but-empty/whitespace class is rejected here. An absent
+      // (`undefined`) class is intentionally left untouched — that case is
+      // out of scope for this validation and handled separately.
+      if (
+        templateDefinition.class !== undefined &&
+        !templateDefinition.class.trim()
+      ) {
+        KetcherLogger.error(
+          `Editor::updateMonomersLibrary: Load of monomer group template "${templateDefinition.name}" (template: ${templateRef.$ref}) has failed. ${MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE} The template was not added to the library.`,
+        );
+        return;
+      }
+
       // eslint-disable-next-line  @typescript-eslint/no-non-null-assertion
       this._monomersLibraryParsedJson![templateRef.$ref] = templateDefinition;
       if (

packages/ketcher-core/src/utilities/monomers.ts

@@ -18,6 +18,9 @@ export const MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH = 200;
 
 export const MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH_ERROR_MESSAGE = `The monomer group template name must not exceed ${MONOMER_GROUP_TEMPLATE_NAME_MAX_LENGTH} characters.`;
 
+export const MONOMER_GROUP_TEMPLATE_CLASS_EMPTY_ERROR_MESSAGE =
+  'The monomer group template class cannot be empty or whitespace.';
+
 const HELM_ALIAS_REGEX = /^(?!.*\s)[A-Za-z0-9_*.[\]()-]+$/;
 const BILN_ALIAS_REGEX = /^[A-Za-z0-9_*-]+$/;