Refactor: Fix serializer circular dependency#10093
Merged
AlexeyGirin merged 1 commit intoMay 21, 2026
Merged
Conversation
svvald
approved these changes
May 20, 2026
AlexeyGirin
merged commit 16cfd2b
into
fix-sequence-view-circ-dep
14 of 15 checks passed
AlexeyGirin
added a commit
that referenced
this pull request
May 21, 2026
* break SnakeLayotModel cycles * fix few barrel dependencies cycles * fix few barrel dependencies cycles * fix editor barrel imports * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break SequenceRenderer circular deps * break serializer circular dependency (#10093) * Merge fix-circular-dependencies-10: resolve conflicts, fix RGroupAttachmentPoint TS type error Agent-Logs-Url: https://github.com/epam/ketcher/sessions/163e39f7-0c9b-4473-a9f0-9b0ab50ff6e4 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
AlexeyGirin
added a commit
that referenced
this pull request
May 21, 2026
* break SequenceRenderer cycle * brake ketSerializer cycles * break ketSerializer cycles * break ketSerializer cycles * Revert "break SequenceRenderer cycle" This reverts commit 6d9bc2f. * break ketSerializer cycles * Reapply "break SequenceRenderer cycle" This reverts commit ad6c992. * break SnakeMode circular dependencies * break monomerFactory circular dependencies * break monomerFactory circular dependencies * break monomerFactory circular dependencies * Refactor: break SnakeLayoutModel circular dependencies (#10056) * break SnakeLayotModel cycles * Refactor: fix barrel imports circular dependencies (#10058) * fix few barrel dependencies cycles * fix few barrel dependencies cycles * Refactor: fix editor barrel imports (#10078) * fix editor barrel imports * Refactor: Break 4 circular dependencies (#10079) * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break RGRoupAttachmentPoint circular dep * break RGRoupAttachmentPoint circular dep * Refactor: fix SequenceRenderer circular deps (#10088) * break SnakeLayotModel cycles * fix few barrel dependencies cycles * fix few barrel dependencies cycles * fix editor barrel imports * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break circular deps: file extraction, barrel bypass, class co-location * break SequenceRenderer circular deps * break serializer circular dependency (#10093) * Merge fix-circular-dependencies-10: resolve conflicts, fix RGroupAttachmentPoint TS type error Agent-Logs-Url: https://github.com/epam/ketcher/sessions/163e39f7-0c9b-4473-a9f0-9b0ab50ff6e4 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original cycle:
src/domain/serializers/index.ts->src/domain/serializers/ket/index.ts->src/domain/serializers/ket/ketSerializer.ts->src/domain/entities/DrawingEntitiesManager.ts->src/domain/serializers/index.tsFix: replace barrel import with direct imports
Check list
#1234 – issue name