Small pnpm adjustments (#1175)

* build: new try pinning dependencies

* build: last missing version pins

* build: replace npm with pnpm

* build: move sections from package.json, prettier ignore lockfile

* build: fix phantom dependencies and remove a few useless ones

* build: update ci to use pnpm

* build: update Dockerfile

* build: update npm calls to pnpm

* build: simplify building examples

* build: fix e2e tests

* build: don't build code in start command

* build: update args passing to pnpm (no -- separator)

* ci: sync lockfile

* docs: update docs to mention pnpm instead of npm

* docs: update tools installation guide

* chore: formatting

* build: bump typescript to 6

* build: bump typescript-eslint

* lint: don't ignore docs/examples

* lint: ignore buggy rule for `webapp`

* chore: fix lint errors in discojs

* chore: fix gitignore patterns

* chore: formatted previously gitignored code

* chore: make knip pass

- adjust dependencies
- remove unused exports
- refine knip config

* ci: add knip to ci

* chore: sync lockfile

* build: deduplicate dependencies

* build: make isomorphic-wrtc a workspace dependency

* build: add `isomorphic-wrtc` to workspaces

* ci: knip ignore dependency (necessary for deduplicating deps)

* build: drop corepack

* build: don't use pnpm install script either

* docs: change pnpm install instructions, document buggy behavior fix

* docs: link new file

Author: hleepfl

.knip.json

@@ -2,7 +2,7 @@
   "workspaces": {
     ".": {
       "ignore": ["docs/**"],
-      "ignoreDependencies": ["typescript-eslint"]
+      "ignoreDependencies": ["typescript-eslint", "supports-color"]
     },
     "webapp": {
       "ignore": ["env.d.ts"],

DEV.md

@@ -71,12 +71,7 @@ Use it to install the version we use in DISCO.
 nvm install # it reads `.nvmrc` to select the correct version
 ```
 
-To use pnpm, you can use corepack, which usually comes bundled with Node.js
-
-```
-corepack enable
-corepack use pnpm
-```
+To use pnpm, you can follow their [installation instructions](https://pnpm.io/installation)
 
 `nvm` manages your different Node.js versions while `pnpm` handles your different Node.js project packages within one version.
 
@@ -193,6 +188,7 @@ As there are many guides in the project, here is a table of contents referencing
   - [Privacy in DISCO](./docs/PRIVACY.md)
   - [Vue.js in DISCO](./docs/VUEJS.md)
   - [FAQ](./docs/FAQ.md)
+  - [Notes about tooling](./docs/TOOLING.md)
 - `README` files contain information relevant to their respective module:
   - [`server` README](./server/README.md), with API and deployment information
   - [`cli` README](./cli/README.md)

Dockerfile

@@ -1,7 +1,7 @@
 # TODO freeze to 22 until tfjs#8425 is merged
 FROM node:22 AS builder
 
-RUN corepack enable
+RUN npm i -g pnpm
 
 WORKDIR /disco
 
@@ -27,18 +27,17 @@ FROM node:22-slim AS runner
 
 WORKDIR /disco
 
-RUN corepack enable
+RUN npm i -g pnpm
 
 COPY --link --from=builder /disco/package.json /disco/pnpm*.yaml /disco/
 COPY --link --from=builder /disco/isomorphic-wrtc/package.json isomorphic-wrtc/
 COPY --link --from=builder /disco/discojs/package.json discojs/
 COPY --link --from=builder /disco/discojs-node/package.json discojs-node/
 COPY --link --from=builder /disco/server/package.json server/
 
-# We need to copy the file dependency before installing
-COPY --link --from=builder /disco/isomorphic-wrtc/ isomorphic-wrtc/
 RUN pnpm --prod ci
 
+COPY --link --from=builder /disco/isomorphic-wrtc/ isomorphic-wrtc/
 COPY --link --from=builder /disco/discojs/dist/ discojs/dist/
 COPY --link --from=builder /disco/discojs-node/dist/ discojs-node/dist/
 COPY --link --from=builder /disco/server/dist/ server/dist/

discojs/package.json

@@ -18,7 +18,7 @@
   },
   "homepage": "https://github.com/epfml/disco#readme",
   "dependencies": {
-    "@epfml/isomorphic-wrtc": "file:../isomorphic-wrtc",
+    "@epfml/isomorphic-wrtc": "workspace:*",
     "@jimp/core": "1.6.1",
     "@jimp/plugin-resize": "1.6.1",
     "@msgpack/msgpack": "3.1.3",

docs/TOOLING.md

@@ -0,0 +1,6 @@
+# General tooling documentation
+
+## Dependencies
+
+We use `supports-color` as a root dev-dependency because when it is not declared it causes some bugs in pnpm v11.9, leading to duplicate dependencies and alternating constantly between versions of dependencies. The goal is to get it removed if the behavior gets fixed in future pnpm versions.  
+To check with a new version, run `pnpm i`, then remove the dependency and `pnpm i` again. If something changes, it's still broken

package.json

@@ -20,9 +20,16 @@
     "eslint-plugin-vue": "10.8.0",
     "knip": "6.17.1",
     "prettier": "3.6.2",
+    "supports-color": "8.1.1",
     "typescript": "catalog:",
     "typescript-eslint": "8.62.1",
     "vitest": "catalog:"
   },
-  "packageManager": "pnpm@11.8.0+sha512.c1f5e7c4cb241c8f174b743851d82f42b802324afc8b0f116b96adb15aa06664948dde36960a3ba1079ba5b4b29dd0140135b94b5b5f5263592249d68e555f26"
+  "devEngines": {
+    "packageManager": {
+      "name": "pnpm",
+      "version": ">=11.0.0 <12.0.0",
+      "onFail": "download"
+    }
+  }
 }