Worker name mismatch#9
Merged
Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
kentcdodds
commented
Feb 7, 2026
Comment on lines
+19
to
+20
| // Keep this in sync with top-level "name" to avoid "-production". | ||
| "name": "epicflare", |
Member
Author
There was a problem hiding this comment.
@cursor, didn't realize this was how it's done by default with wrangler. Let's remove this line and update our workflow to handle the -production env.
There was a problem hiding this comment.
Summary
- Removed the production
nameoverride so Wrangler uses the default{name}-productionworker, while the deploy workflow continues to target production secrets via--env production.【F:wrangler.jsonc†L1-L46】【F:.github/workflows/deploy.yml†L134-L141】
Testing
- ❌
bun run validate(full gate required by repo; fails intypecheckdue to duplicate@modelcontextprotocol/sdktypes inagents, unrelated to this change).【ca05b7†L1-L49】 - Manual testing not run because this is a deploy config-only change with no UI/runtime behavior to exercise locally.
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Set production worker name explicitly and target secrets to the production environment to resolve
COOKIE_SECRETundefined error.The previous configuration caused a mismatch where
wranglerwould automatically suffix the production worker name with-production(e.g.,epicflare-production), but secrets were being put into the base worker name (e.g.,epicflare). This resulted in theCOOKIE_SECRETbeing unavailable to the deployed production worker. This change ensures the production worker name is consistent and secrets are correctly associated.Note
Low Risk
Workflow-only change that adjusts where a secret is written; limited blast radius but could still break deploys if the env name/config is incorrect.
Overview
Fixes production deploy secret scoping by updating the GitHub Actions workflow to write
COOKIE_SECRETviawrangler secret put ... --env production, ensuring the deployed worker can read the secret.Also tweaks
docs/agents/setup.mdformatting for the local.envsetup instruction (line wrap only).Written by Cursor Bugbot for commit 17a66da. This will update automatically on new commits. Configure here.