Dependency package updates (#39)

kentcdodds · web-flow · commit 40f49fb608cc · 2026-01-30T10:16:31.000-07:00
diff --git a/app/components/error-boundary.tsx b/app/components/error-boundary.tsx
@@ -5,12 +5,13 @@ import {
 	useRouteError,
 } from '@remix-run/react'
 import { captureRemixErrorBoundaryError } from '@sentry/remix'
+import { type ReactElement } from 'react'
 import { getErrorMessage } from '#app/utils/misc.tsx'
 
 type StatusHandler = (info: {
 	error: ErrorResponse
 	params: Record<string, string | undefined>
-}) => JSX.Element | null
+}) => ReactElement | null
 
 export function GeneralErrorBoundary({
 	defaultStatusHandler = ({ error }) => (
@@ -23,7 +24,7 @@ export function GeneralErrorBoundary({
 }: {
 	defaultStatusHandler?: StatusHandler
 	statusHandlers?: Record<number, StatusHandler>
-	unexpectedErrorHandler?: (error: unknown) => JSX.Element | null
+	unexpectedErrorHandler?: (error: unknown) => ReactElement | null
 }) {
 	const error = useRouteError()
 	captureRemixErrorBoundaryError(error)
diff --git a/app/components/forms.tsx b/app/components/forms.tsx
@@ -193,7 +193,7 @@ export function CheckboxField({
 	errors,
 	className,
 }: {
-	labelProps: JSX.IntrinsicElements['label']
+	labelProps: React.LabelHTMLAttributes<HTMLLabelElement>
 	buttonProps: CheckboxProps & {
 		name: string
 		form: string
diff --git a/app/root.tsx b/app/root.tsx
@@ -100,7 +100,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
 		await logout({ request, redirectTo: '/' })
 	}
 	const { toast, headers: toastHeaders } = await getToast(request)
-	const honeyProps = honeypot.getInputProps()
+	const honeyProps = await honeypot.getInputProps()
 
 	return json(
 		{
diff --git a/app/routes/_app+/_auth+/forgot-password.tsx b/app/routes/_app+/_auth+/forgot-password.tsx
@@ -57,7 +57,7 @@ function getIdentifier({
 
 export async function action({ request }: ActionFunctionArgs) {
 	const formData = await request.formData()
-	checkHoneypot(formData)
+	await checkHoneypot(formData)
 	const submission = await parseWithZod(formData, {
 		schema: ForgotPasswordSchema.superRefine(async (data, ctx) => {
 			const identifier = getIdentifier({ countryCode: data.countryCode, phoneNumber: data.phoneNumber })
diff --git a/app/routes/_app+/_auth+/login.tsx b/app/routes/_app+/_auth+/login.tsx
@@ -48,7 +48,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
 export async function action({ request }: ActionFunctionArgs) {
 	await requireAnonymous(request)
 	const formData = await request.formData()
-	checkHoneypot(formData)
+	await checkHoneypot(formData)
 	const submission = await parseWithZod(formData, {
 		schema: (intent) =>
 			LoginFormSchema.transform(async (data, ctx) => {
diff --git a/app/routes/_app+/_auth+/onboarding.tsx b/app/routes/_app+/_auth+/onboarding.tsx
@@ -62,7 +62,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
 export async function action({ request }: ActionFunctionArgs) {
 	const phoneNumber = await requireOnboardingPhoneNumber(request)
 	const formData = await request.formData()
-	checkHoneypot(formData)
+	await checkHoneypot(formData)
 	const submission = await parseWithZod(formData, {
 		schema: (intent) =>
 			SignupFormSchema.superRefine(async (data, ctx) => {
diff --git a/app/routes/_app+/_auth+/signup.tsx b/app/routes/_app+/_auth+/signup.tsx
@@ -40,7 +40,7 @@ const countryCodes = [
 export async function action({ request }: ActionFunctionArgs) {
 	const formData = await request.formData()
 
-	checkHoneypot(formData)
+	await checkHoneypot(formData)
 
 		const submission = await parseWithZod(formData, {
 			schema: SignupSchema.superRefine(async (data, ctx) => {
diff --git a/app/routes/_app+/_auth+/verify.tsx b/app/routes/_app+/_auth+/verify.tsx
@@ -35,7 +35,7 @@ export const VerifySchema = z.object({
 
 export async function action({ request }: ActionFunctionArgs) {
 	const formData = await request.formData()
-	checkHoneypot(formData)
+	await checkHoneypot(formData)
 	return validateRequest(request, formData)
 }
 
diff --git a/app/utils/cron.server.ts b/app/utils/cron.server.ts
@@ -4,7 +4,7 @@
  * it gets us.
  */
 import { remember } from '@epic-web/remember'
-import cronParser from 'cron-parser'
+import { CronExpressionParser } from 'cron-parser'
 import {
 	clearIntervalAsync,
 	setIntervalAsync,
@@ -24,7 +24,7 @@ export class CronParseError extends Error {
 
 function parseCronExpression(cronString: string, options?: { tz?: string }) {
 	try {
-		return cronParser.parseExpression(cronString, options)
+		return CronExpressionParser.parse(cronString, options)
 	} catch (error) {
 		const errorMessage =
 			error instanceof Error ? error.message : 'Invalid cron string'
diff --git a/app/utils/cron.ts b/app/utils/cron.ts
@@ -1,11 +1,11 @@
-import cronParser from 'cron-parser'
+import { CronExpressionParser } from 'cron-parser'
 
 export function validateCronString(cronString: string): {
 	valid: boolean
 	error?: string
 } {
 	try {
-		cronParser.parseExpression(cronString)
+		CronExpressionParser.parse(cronString)
 		return { valid: true }
 	} catch (error) {
 		const errorMessage =
diff --git a/app/utils/honeypot.server.ts b/app/utils/honeypot.server.ts
@@ -5,9 +5,9 @@ export const honeypot = new Honeypot({
 	encryptionSeed: process.env.HONEYPOT_SECRET,
 })
 
-export function checkHoneypot(formData: FormData) {
+export async function checkHoneypot(formData: FormData) {
 	try {
-		honeypot.check(formData)
+		await honeypot.check(formData)
 	} catch (error) {
 		if (error instanceof SpamError) {
 			throw new Response('Form not submitted properly', { status: 400 })
diff --git a/app/utils/litefs.server.ts b/app/utils/litefs.server.ts
@@ -7,4 +7,4 @@ export {
 	getInternalInstanceDomain,
 	getInstanceInfoSync,
 } from 'litefs-js'
-export { ensurePrimary, ensureInstance } from 'litefs-js/remix.js'
+export { ensurePrimary, ensureInstance } from 'litefs-js/remix'
diff --git a/app/utils/misc.use-double-check.test.tsx b/app/utils/misc.use-double-check.test.tsx
@@ -29,7 +29,7 @@ function TestComponent({ safeDelayMs = 0 }: { safeDelayMs?: number }) {
 
 test('prevents default on the first click, and does not on the second', async () => {
 	const user = userEvent.setup()
-	render(<TestComponent safeDelayMs={50} />)
+	render(<TestComponent safeDelayMs={200} />)
 
 	const status = screen.getByRole('status')
 	const button = screen.getByRole('button')
@@ -40,13 +40,17 @@ test('prevents default on the first click, and does not on the second', async ()
 	await user.click(button)
 	expect(button).toHaveTextContent('You sure?')
 	expect(status).toHaveTextContent('Default Prevented: yes')
-	expect(button).toHaveAttribute('data-safe-delay', 'true')
+	await waitFor(() =>
+		expect(button).toHaveAttribute('data-safe-delay', 'true'),
+	)
 
 	// clicking it during the safe delay does nothing
 	await user.click(button)
 	expect(button).toHaveTextContent('You sure?')
 	expect(status).toHaveTextContent('Default Prevented: yes')
-	expect(button).toHaveAttribute('data-safe-delay', 'true')
+	await waitFor(() =>
+		expect(button).toHaveAttribute('data-safe-delay', 'true'),
+	)
 
 	await waitFor(() =>
 		expect(button).toHaveAttribute('data-safe-delay', 'false'),
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
diff --git a/tests/e2e/send.test.ts b/tests/e2e/send.test.ts

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ export async function loader({ request }: LoaderFunctionArgs) {`
`100`	`100`	`await logout({ request, redirectTo: '/' })`
`101`	`101`	`}`
`102`	`102`	`const { toast, headers: toastHeaders } = await getToast(request)`
`103`		`- const honeyProps = honeypot.getInputProps()`
	`103`	`+ const honeyProps = await honeypot.getInputProps()`
`104`	`104`
`105`	`105`	`return json(`
`106`	`106`	`{`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export const VerifySchema = z.object({`
`35`	`35`
`36`	`36`	`export async function action({ request }: ActionFunctionArgs) {`
`37`	`37`	`const formData = await request.formData()`
`38`		`- checkHoneypot(formData)`
	`38`	`+ await checkHoneypot(formData)`
`39`	`39`	`return validateRequest(request, formData)`
`40`	`40`	`}`
`41`	`41`