Prisma query performance (#65)

* Optimize healthcheck query

Co-authored-by: me <me@kentcdodds.com>

* Add indexes for slow queries

Co-authored-by: me <me@kentcdodds.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: kentcdodds

app/routes/resources+/healthcheck.tsx

@@ -2,22 +2,10 @@
 import { type LoaderFunctionArgs } from 'react-router'
 import { prisma } from '#app/utils/db.server.ts'
 
-export async function loader({ request }: LoaderFunctionArgs) {
-	const host =
-		request.headers.get('X-Forwarded-Host') ?? request.headers.get('host')
-
+export async function loader(_args: LoaderFunctionArgs) {
 	try {
-		// if we can connect to the database and make a simple query
-		// and make a HEAD request to ourselves, then we're good.
-		await Promise.all([
-			prisma.user.count(),
-			fetch(`${new URL(request.url).protocol}${host}`, {
-				method: 'HEAD',
-				headers: { 'X-Healthcheck': 'true' },
-			}).then((r) => {
-				if (!r.ok) return Promise.reject(r)
-			}),
-		])
+		// If we can connect and run a trivial query, then we're good.
+		await prisma.$queryRaw`SELECT 1`
 		return new Response('OK')
 	} catch (error: unknown) {
 		console.log('healthcheck ❌', { error })

docs/skills/epic-deployment/SKILL.md

@@ -116,18 +116,9 @@ tls_skip_verify = false
 
 ```typescript
 // app/routes/resources/healthcheck.tsx
-export async function loader({ request }: Route.LoaderArgs) {
-	const host =
-		request.headers.get('X-Forwarded-Host') ?? request.headers.get('host')
-
+export async function loader(_args: Route.LoaderArgs) {
 	try {
-		await Promise.all([
-			prisma.user.count(), // Verify DB
-			fetch(`${new URL(request.url).protocol}${host}`, {
-				method: 'HEAD',
-				headers: { 'X-Healthcheck': 'true' },
-			}),
-		])
+		await prisma.$queryRaw`SELECT 1` // Verify DB connectivity
 		return new Response('OK')
 	} catch (error) {
 		console.log('healthcheck ❌', { error })

docs/skills/epic-routing/SKILL.md

@@ -200,19 +200,10 @@ Resource routes don't render UI; they only return data or perform actions.
 
 ```typescript
 // app/routes/resources/healthcheck.tsx
-export async function loader({ request }: Route.LoaderArgs) {
+export async function loader(_args: Route.LoaderArgs) {
 	// Check application health
-	const host =
-		request.headers.get('X-Forwarded-Host') ?? request.headers.get('host')
-
 	try {
-		await Promise.all([
-			prisma.user.count(), // Check DB
-			fetch(`${new URL(request.url).protocol}${host}`, {
-				method: 'HEAD',
-				headers: { 'X-Healthcheck': 'true' },
-			}),
-		])
+		await prisma.$queryRaw`SELECT 1` // Check DB connectivity
 		return new Response('OK')
 	} catch (error) {
 		return new Response('ERROR', { status: 500 })

prisma/migrations/20260201014000-add-query-indexes/migration.sql

@@ -0,0 +1,8 @@
+-- CreateIndex
+CREATE INDEX "User_stripeId_idx" ON "User"("stripeId");
+
+-- CreateIndex
+CREATE INDEX "Recipient_verified_disabled_idx" ON "Recipient"("verified", "disabled");
+
+-- CreateIndex
+CREATE INDEX "Message_recipientId_sentAt_order_idx" ON "Message"("recipientId", "sentAt", "order");

prisma/schema.prisma

@@ -24,6 +24,8 @@ model User {
   roles      Role[]
   sessions   Session[]
   recipients Recipient[]
+
+  @@index([stripeId])
 }
 
 model Password {
@@ -125,6 +127,7 @@ model Recipient {
 
   // non-unique foreign key
   @@index([userId])
+  @@index([verified, disabled])
 }
 
 model Message {
@@ -142,6 +145,7 @@ model Message {
 
   // non-unique foreign key
   @@index([recipientId])
+  @@index([recipientId, sentAt, order])
 }
 
 model SourceNumber {