Express dependency upgrades#37
Merged
Merged
Conversation
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
express,express-rate-limit, and@types/expressto their latest versions. This required updating Express wildcard routes from string patterns to regex patterns to align with Express 5's routing behavior. An e2e test assertion was also updated to reflect a minor UI text change.Test Plan
Full gate (
npm run validate) was executed to ensure no regressions. No manual UI testing was performed as changes are dependency/server/test-only, and automated e2e tests cover UI flows.Checklist
Screenshots
N/A - Dependency and server-side changes.
Note
Medium Risk
Express major-version upgrade plus routing-pattern changes can subtly affect request matching and middleware execution order; changes are localized and covered by automated tests.
Overview
Upgrades server dependencies to
express@5,express-rate-limit@8, and@types/express@5, with the correspondingpackage-lock.jsonrefresh.Updates Express route matching in
server/index.tsto use regex-based catch-alls and static-path handlers (replacing'*'and['/img/*','/favicons/*']) to align with Express 5 routing behavior, and adjusts one Playwright assertion to match updated “no past messages yet” UI copy.Written by Cursor Bugbot for commit 9601d68. This will update automatically on new commits. Configure here.