Totp algorithm migration#38
Merged
Merged
Conversation
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
@epic-web/totpto v4.0.1, addressing breaking changes by:async.SHA1toSHA-1) intotp.server.tsfor backward compatibility.Verificationrecords in the database to the newSHA-Xalgorithm format.Test Plan
PORT=3001 npm run test:e2e:run -- tests/e2e/2fa.test.tsto verify the 2FA flow.Checklist
Screenshots
https://github.com/epicweb-dev/epic-stack/assets/1500684/10427387-9878-4395-8968-381907720977

Note
Medium Risk
Touches login/2FA verification logic and introduces a DB migration that rewrites stored TOTP algorithms; mistakes could break authentication for existing users or invalidate codes.
Overview
Upgrades
@epic-web/totpto^4.0.1and updates 2FA/verification flows to use the library’s now-asyncgenerateTOTP/verifyTOTPAPIs (including updating default algorithm strings toSHA-256).Replaces the
totp.server.tsre-export with wrapper functions that normalize algorithm names (SHA1/SHA256/SHA512→SHA-1/SHA-256/SHA-512) and adds a Prisma migration to rewrite existingVerification.algorithmvalues in the DB; e2e 2FA tests are updated to await OTP generation.Written by Cursor Bugbot for commit 485d703. This will update automatically on new commits. Configure here.