Verify page visual consistency#53
Merged
Merged
Conversation
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: me <me@kentcdodds.com>
Co-authored-by: me <me@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the verify page to better match the provided design. Key changes include:
OTPFieldcomponent (slotClassName,groupClassName,separatorClassName,showSeparator) to allow for greater customization.Test Plan
npm run dev).http://localhost:3000/verify?type=onboarding&target=15555555555.Checklist
Screenshots
Note
Low Risk
Primarily styling/layout updates plus a backwards-compatible
OTPFieldAPI extension; low risk aside from potential visual regressions in OTP rendering where new optional props are used.Overview
Updates the
/verifypage UI to match the latest design: refactors headings into a shared builder, adjusts layout/spacing, repositions error rendering, and tweaks the resend link styling.Extends
OTPFieldto support customizable OTP slot/group/separator classes and optionally hide the separator, then uses these new props on the verify form to render circular OTP slots and remove the separator; the submit button is also updated to a larger style and includes an arrow icon.Written by Cursor Bugbot for commit 24eeab3. This will update automatically on new commits. Configure here.