Skip to content

Commit 7065091

Browse files
committed
update eslint and try concurrency
1 parent 52c9d96 commit 7065091

File tree

15 files changed

+5285
-4518
lines changed

15 files changed

+5285
-4518
lines changed

.github/workflows/validate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ jobs:
3333
run: npm run typecheck
3434

3535
# TODO: re-enable linting
36-
# - name: ⬣ ESLint
37-
# run: npm run lint
36+
- name: ⬣ ESLint
37+
run: npm run lint
3838

3939
# TODO: get this working again
4040
# - name: ⬇️ Install Playwright

epicshop/package-lock.json

Lines changed: 1863 additions & 1941 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

epicshop/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
"test": "playwright test && node test.js"
66
},
77
"dependencies": {
8-
"@epic-web/config": "^1.16.4",
8+
"@epic-web/config": "^1.21.3",
99
"@epic-web/workshop-app": "^6.23.4",
1010
"@epic-web/workshop-utils": "^6.23.4",
1111
"enquirer": "^2.4.1",
12-
"execa": "^9.5.2",
13-
"match-sorter": "^8.0.0",
14-
"p-limit": "^6.1.0",
12+
"execa": "^9.6.0",
13+
"match-sorter": "^8.1.0",
14+
"p-limit": "^7.1.0",
1515
"@epic-web/workshop-cli": "^6.23.4"
1616
}
1717
}

exercises/04.code-splitting/03.problem.transition/tests/flash.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ test('should still show a pending UI when the globe is not ready', async ({
4343
await page.goto('/')
4444
await page.waitForLoadState('networkidle')
4545

46-
await page.route('**/*', (route) => {
46+
await page.route('**/*', async (route) => {
4747
if (route.request().resourceType() === 'script') {
4848
setTimeout(() => route.continue(), 600) // Simulate a slow load time for scripts
4949
} else {
50-
route.continue()
50+
await route.continue()
5151
}
5252
})
5353

exercises/04.code-splitting/03.solution.transition/tests/flash.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ test('should still show a pending UI when the globe is not ready', async ({
4343
await page.goto('/')
4444
await page.waitForLoadState('networkidle')
4545

46-
await page.route('**/*', (route) => {
46+
await page.route('**/*', async (route) => {
4747
if (route.request().resourceType() === 'script') {
4848
setTimeout(() => route.continue(), 600) // Simulate a slow load time for scripts
4949
} else {
50-
route.continue()
50+
await route.continue()
5151
}
5252
})
5353

exercises/05.calculations/01.problem.use-memo/tests/use-memo.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export { searchCitiesInstrumented as searchCities }
2424
`
2525
content = `${content}\n\n${instrumentedCode}`
2626

27-
route.fulfill({ body: content, headers: response.headers() })
27+
await route.fulfill({ body: content, headers: response.headers() })
2828
})
2929
await page.goto('/')
3030
await page.waitForLoadState('networkidle')

exercises/05.calculations/01.solution.use-memo/tests/use-memo.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export { searchCitiesInstrumented as searchCities }
2424
`
2525
content = `${content}\n\n${instrumentedCode}`
2626

27-
route.fulfill({ body: content, headers: response.headers() })
27+
await route.fulfill({ body: content, headers: response.headers() })
2828
})
2929
await page.goto('/')
3030
await page.waitForLoadState('networkidle')

exercises/06.rerenders/01.problem.memo/tests/memoized.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
7474
</script>
7575
`
7676
html = html.replace('<head>', `<head>${scriptToInject}`)
77-
route.fulfill({ body: html, headers: { 'content-type': 'text/html' } })
77+
await route.fulfill({
78+
body: html,
79+
headers: { 'content-type': 'text/html' },
80+
})
7881
})
7982

8083
await page.goto('/')

exercises/06.rerenders/01.solution.memo/tests/memoized.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ test('Only ListItem should not rerender when clicking force rerender', async ({
7474
</script>
7575
`
7676
html = html.replace('<head>', `<head>${scriptToInject}`)
77-
route.fulfill({ body: html, headers: { 'content-type': 'text/html' } })
77+
await route.fulfill({
78+
body: html,
79+
headers: { 'content-type': 'text/html' },
80+
})
7881
})
7982

8083
await page.goto('/')

exercises/06.rerenders/02.problem.comparator/tests/memoized.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ test('Only two ListItems should not rerender when the highlighted item changes',
7474
</script>
7575
`
7676
html = html.replace('<head>', `<head>${scriptToInject}`)
77-
route.fulfill({ body: html, headers: { 'content-type': 'text/html' } })
77+
await route.fulfill({
78+
body: html,
79+
headers: { 'content-type': 'text/html' },
80+
})
7881
})
7982

8083
await page.goto('/')

0 commit comments

Comments
 (0)