fix: rename rc.conf user variable to avoid rc.subr conflict

rc.subr interprets ${name}_user as a magic variable and runs the
entire command as that user before daemon(8) gets invoked. This
caused daemon to fail writing the pidfile to /var/run/. Rename to
epithet_server_runas so daemon starts as root, writes the pidfile,
then drops to the epithet user via -u.

Author: brianm

contrib/freebsd/README.md

@@ -55,7 +55,7 @@ pkg add ./epithet-*.pkg
 |---|---|---|
 | `epithet_server_enable` | `NO` | Enable the server service |
 | `epithet_server_config` | `/usr/local/etc/epithet/server.yaml` | Config file path |
-| `epithet_server_user` | `epithet` | User to run as |
+| `epithet_server_runas` | `epithet` | User to run as |
 | `epithet_server_logfile` | `/var/log/epithet_server.log` | Log file path |
 
 Server settings like `listen` and `ca-key` are configured in the YAML config file, not in `rc.conf`.

contrib/freebsd/rc.d/epithet_server

@@ -10,10 +10,10 @@
 #                                 Set it to YES to enable epithet server.
 # epithet_server_config (path):   Path to config file.
 #                                 Default: /usr/local/etc/epithet/server.yaml
-# epithet_server_user (str):      User to run as.
-#                                 Default: epithet
 # epithet_server_logfile (path):  Path to log file.
 #                                 Default: /var/log/epithet_server.log
+# epithet_server_runas (str):     User to run as.
+#                                 Default: epithet
 
 . /etc/rc.subr
 
@@ -24,12 +24,12 @@ load_rc_config $name
 
 : ${epithet_server_enable:="NO"}
 : ${epithet_server_config:="/usr/local/etc/epithet/server.yaml"}
-: ${epithet_server_user:="epithet"}
 : ${epithet_server_logfile:="/var/log/epithet_server.log"}
+: ${epithet_server_runas:="epithet"}
 
 pidfile="/var/run/${name}.pid"
 procname="/usr/local/bin/epithet"
 command="/usr/sbin/daemon"
-command_args="-f -P ${pidfile} -u ${epithet_server_user} ${procname} --config ${epithet_server_config} --log-file ${epithet_server_logfile} server"
+command_args="-f -P ${pidfile} -u ${epithet_server_runas} ${procname} --config ${epithet_server_config} --log-file ${epithet_server_logfile} server"
 
 run_rc_command "$1"