Skip to content

Remove DiagrammeR in favour of mermaid#163

Merged
avallecam merged 3 commits into
mainfrom
fix/162-remove-diagrammer
Jun 12, 2026
Merged

Remove DiagrammeR in favour of mermaid#163
avallecam merged 3 commits into
mainfrom
fix/162-remove-diagrammer

Conversation

@avallecam

Copy link
Copy Markdown
Member

Summary

  • Remove dead library(DiagrammeR), library(webshot), and webshot::install_phantomjs() setup chunks from episodes/contact-matrices.Rmd and episodes/simulating-transmission.Rmd — all diagrams already used native mermaid flowchart syntax
  • Update CONTRIBUTING.md to point new contributors to mermaid instead of DiagrammeR
  • Remove DiagrammeR from renv/profiles/lesson-requirements/renv.lock via renv::remove() + renv::snapshot()

Closes #162

Test plan

  • Verify mermaid diagrams still render in both episodes (SIR in contact-matrices, SEIR in simulating-transmission)
  • Confirm no build errors from missing DiagrammeR/webshot

🤖 Generated with Claude Code

avallecam and others added 2 commits June 12, 2026 12:05
All diagrams were already using mermaid flowchart syntax; the DiagrammeR
library() calls and webshot::install_phantomjs() setup chunks were dead
code. Update CONTRIBUTING.md to point contributors to mermaid instead.

Closes #162

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-late/compare/md-outputs..md-outputs-PR-163

The following changes were observed in the rendered markdown documents:

 config.yaml (gone)         |   84 -
 contact-matrices.md        |    2 -
 md5sum.txt                 |   36 +-
 renv.lock (gone)           | 5579 --------------------------------------------
 simulating-transmission.md |    2 -
 5 files changed, 18 insertions(+), 5685 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-06-12 11:27:25 +0000

@avallecam avallecam merged commit 3393a2e into main Jun 12, 2026
8 checks passed
@avallecam avallecam deleted the fix/162-remove-diagrammer branch June 12, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Diagrammer in favour of mermaid

1 participant