chore: remove stale deterministic-tests feature references#108
Open
punk-dev-robot wants to merge 2 commits into
Open
chore: remove stale deterministic-tests feature references#108punk-dev-robot wants to merge 2 commits into
deterministic-tests feature references#108punk-dev-robot wants to merge 2 commits into
Conversation
added 2 commits
May 29, 2026 08:52
The `deterministic-tests` cargo feature was removed upstream in ad6ded9 ("Simplify (eqtylab#94)") along with the Trust System whose HMAC key derivation it made deterministic. CI workflows were updated to plain `cargo test`, but docs, the `.cargo` aliases, and the example fixture still referenced the removed feature — so `cargo t` and every documented test command failed with "package 'cupcake-core' does not contain this feature". - `.cargo/config.toml`: `t` alias -> `test --workspace`; drop dead `test-deterministic` alias. - CLAUDE.md / CONTRIBUTING.md: document `cargo test --workspace` / `just test`. - examples/fixtures/context_injection.rego: fix injected test reminder. - .github docs/instructions: drop the flag from command examples and reword checklist items toward test isolation/determinism. No behavior change; docs/config only.
Follow-up to c2df2e1: the deterministic-tests cleanup updated the test command examples but left two explanatory blocks still citing the removed `deterministic-tests` feature flag and the removed Trust System (pr-review and security-review instructions). Reword both toward test determinism/isolation, consistent with the rest of that cleanup. Docs only, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
deterministic-testscargo feature was removed in #94 but still referenced in docs,.cargoaliases, and a fixture, socargo tfailed withpackage 'cupcake-core' does not contain this feature..cargo/config.toml:t→test --workspace; drop deadtest-deterministic.CLAUDE.md/CONTRIBUTING.md: documentcargo test --workspace/just test.examples/fixtures/context_injection.rego: fix injected reminder..githubdocs: drop the flag and reword the explanatory blocks (removed flag + Trust System no longer referenced).Docs/config only.
rg deterministic-testsnow clean.