Skip to content

fix(builtins): match sensitive-data keywords on filename, not full path #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
punk-dev-robot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(builtins): match sensitive-data keywords on filename, not full path #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions fixtures/global_builtins/claude/sensitive_data_protection.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ is_sensitive_file(path) if {
}

is_sensitive_file(path) if {
lower_path := lower(path)
# Match keywords against the file name only, not the full path. Matching the
# entire path produced false positives: macOS canonicalizes /tmp and /var
# under /private, so the "private" keyword (and "auth") flagged every file
# beneath those roots. Directory-scoped secrets stay covered by the dedicated
# ssh/cloud/package/vcs clauses, which match on their full path prefixes.
segments := split(lower(path), "/")
filename := segments[count(segments) - 1]

# Files with sensitive keywords
sensitive_keywords := {
Expand All @@ -104,7 +110,7 @@ is_sensitive_file(path) if {
}

some keyword in sensitive_keywords
contains(lower_path, keyword)
contains(filename, keyword)
}

is_sensitive_file(path) if {
Expand Down
10 changes: 8 additions & 2 deletions fixtures/global_builtins/factory/sensitive_data_protection.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ is_sensitive_file(path) if {
}

is_sensitive_file(path) if {
lower_path := lower(path)
# Match keywords against the file name only, not the full path. Matching the
# entire path produced false positives: macOS canonicalizes /tmp and /var
# under /private, so the "private" keyword (and "auth") flagged every file
# beneath those roots. Directory-scoped secrets stay covered by the dedicated
# ssh/cloud/package/vcs clauses, which match on their full path prefixes.
segments := split(lower(path), "/")
filename := segments[count(segments) - 1]

# Files with sensitive keywords
sensitive_keywords := {
Expand All @@ -104,7 +110,7 @@ is_sensitive_file(path) if {
}

some keyword in sensitive_keywords
contains(lower_path, keyword)
contains(filename, keyword)
}

is_sensitive_file(path) if {
Expand Down
10 changes: 8 additions & 2 deletions fixtures/global_builtins/opencode/sensitive_data_protection.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ is_sensitive_file(path) if {
}

is_sensitive_file(path) if {
lower_path := lower(path)
# Match keywords against the file name only, not the full path. Matching the
# entire path produced false positives: macOS canonicalizes /tmp and /var
# under /private, so the "private" keyword (and "auth") flagged every file
# beneath those roots. Directory-scoped secrets stay covered by the dedicated
# ssh/cloud/package/vcs clauses, which match on their full path prefixes.
segments := split(lower(path), "/")
filename := segments[count(segments) - 1]

# Files with sensitive keywords
sensitive_keywords := {
Expand All @@ -104,7 +110,7 @@ is_sensitive_file(path) if {
}

some keyword in sensitive_keywords
contains(lower_path, keyword)
contains(filename, keyword)
}

is_sensitive_file(path) if {
Expand Down