fix: dual scrollbars on code block#103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dual scrollbars in CodeBlock
Was able to reproduce this issue by updating the System Settings → Appearance → Show scroll bars: Always on macOS.
The
<pre>rendered byreact-syntax-highlighterinheritsoverflow: autofrom the Prism theme, which stacks a second scroll container inside.content(with it’s ownoverflow: scroll), ending up in two vertical scrollbars on the same axis..pre: addedoverflow-visible!to kill the inner scrollbar inherited from the theme..content: switchedoverflow-scrolltooverflow-autoso the bar only shows when content actually overflows.Linear ticket: Dual Scrollbars on indicators.
We will need to release the package after merging and upgrade it on Gov Studio to close ticket.
See before:
And after:
