From efa234b4922caa3b19656c3673ccd511510b1e9f Mon Sep 17 00:00:00 2001 From: giuliana-gladeye Date: Wed, 8 Jul 2026 09:45:52 +1200 Subject: [PATCH] feat: updated danger variant on dropdown item --- .../demo/src/components/demo/dropdown-menu.tsx | 2 +- .../demo/src/content/components/dropdown-menu.mdx | 14 +++++++------- .../dropdown-menu/dropdown-menu.module.css | 2 +- .../src/components/dropdown-menu/dropdown-menu.tsx | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/demo/src/components/demo/dropdown-menu.tsx b/packages/demo/src/components/demo/dropdown-menu.tsx index 01b14d7d..2bf47e5c 100644 --- a/packages/demo/src/components/demo/dropdown-menu.tsx +++ b/packages/demo/src/components/demo/dropdown-menu.tsx @@ -47,7 +47,7 @@ export const DropdownMenuDemo = ({ Profile Settings - Logout + Logout diff --git a/packages/demo/src/content/components/dropdown-menu.mdx b/packages/demo/src/content/components/dropdown-menu.mdx index 2d6fcc5c..e882f4b3 100644 --- a/packages/demo/src/content/components/dropdown-menu.mdx +++ b/packages/demo/src/content/components/dropdown-menu.mdx @@ -35,7 +35,7 @@ Basic usage: Profile Settings - Logout + Logout ``` @@ -201,12 +201,12 @@ Wrap related items in `DropdownMenuGroup` to associate a label with its items fo ### DropdownMenuItem -| Name | Description | Type | Default | Required | -| ---------- | ----------------------------------------------------- | ------------ | ------- | -------- | -| `danger` | Styles the item as a destructive action | `boolean` | `false` | ❌ | -| `inset` | Adds left padding to align with items that have icons | `boolean` | `false` | ❌ | -| `disabled` | Prevents interaction and dims the item | `boolean` | `false` | ❌ | -| `onSelect` | Called when the item is selected | `() => void` | - | ❌ | +| Name | Description | Type | Default | Required | +| ---------- | ----------------------------------------------------- | ------------------- | --------- | -------- | +| `variant` | Visual style; `danger` marks a destructive action | `neutral`, `danger` | `neutral` | ❌ | +| `inset` | Adds left padding to align with items that have icons | `boolean` | `false` | ❌ | +| `disabled` | Prevents interaction and dims the item | `boolean` | `false` | ❌ | +| `onSelect` | Called when the item is selected | `() => void` | - | ❌ | ### DropdownMenuCheckboxItem diff --git a/packages/ui/src/components/dropdown-menu/dropdown-menu.module.css b/packages/ui/src/components/dropdown-menu/dropdown-menu.module.css index 36467541..7ccfe97e 100644 --- a/packages/ui/src/components/dropdown-menu/dropdown-menu.module.css +++ b/packages/ui/src/components/dropdown-menu/dropdown-menu.module.css @@ -35,7 +35,7 @@ @apply hover:not-disabled:text-red-700! focus:text-red-700!; @apply hover:not-disabled:bg-red-300/50! focus:bg-red-300/50!; @apply dark:hover:not-disabled:bg-red-600/50! dark:focus:bg-red-600/50!; - @apply dark:hover:not-disabled:text-red-100! dark:focus:text-red-100!; + @apply dark:hover:not-disabled:text-red-200! dark:focus:text-red-200!; } .dropdown-menu-item-indicator-checkbox, diff --git a/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx b/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx index 352d6995..5c242f0a 100644 --- a/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx +++ b/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx @@ -77,15 +77,15 @@ const DropdownMenuItem = React.forwardRef< React.ElementRef, React.ComponentPropsWithoutRef & { inset?: boolean; - danger?: boolean; + variant?: 'neutral' | 'danger'; } ->(({ className, inset, danger, ...props }, ref) => ( +>(({ className, inset, variant = 'neutral', ...props }, ref) => (