Feature/elevation#41
Merged
Merged
Conversation
not yet actually changed from `background` but the tokens exist at least. Remap these to different values!
Remove LLM cruft
- Default is now raised - Minor shadow styling changes
Member
|
This is a big one! Should be ready to go, component docs still need work, but the elevation properties all seem to be in order! Have also clarified some usage guidelines in the elevation docs page. Will do a final overview and merge tomorrow. |
tmccoy14
approved these changes
Jan 22, 2026
Contributor
tmccoy14
left a comment
There was a problem hiding this comment.
This looks good to me - only thing I saw were the errors about declaring variables but never using them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overlayTODOs:
Design:
background,borderandshadowfor each elevationbottomandtopelevation as well - these are used in a couple of places where a component has nested elevations, like the table header in table. Might need renaming?Dev:
package/ui/src/theme-base.csswith aTODOcomment - they need to be added as color tokens instead!dropdown-menu.module.cssandselect.module.cssrequire the use of--mix-colorbut this requires the CSS var which we haven't set yet - addedTODOcomments to these as they will need to be adjusted after the tokens are added!