Skip to content

Feature/elevation#41

Merged
Shrinks99 merged 41 commits into
mainfrom
feature/elevation
Jan 22, 2026
Merged

Feature/elevation#41
Shrinks99 merged 41 commits into
mainfrom
feature/elevation

Conversation

@kate-gladeye
Copy link
Copy Markdown
Collaborator

@kate-gladeye kate-gladeye commented Dec 19, 2025

  • Added elevation levels and props to components which should have them
  • Set all modals to use overlay
  • Added documentation

TODOs:

Design:

  • Add color tokens for all background, border and shadow for each elevation
  • Add color tokens for bottom and top elevation as well - these are used in a couple of places where a component has nested elevations, like the table header in table. Might need renaming?
  • Once the correct colors are added, check that they make sense across all use-cases. Maybe some components need specific adjustments?

Dev:

  • Added temporary elevation colors to package/ui/src/theme-base.css with a TODO comment - they need to be added as color tokens instead!
  • dropdown-menu.module.css and select.module.css require the use of --mix-color but this requires the CSS var which we haven't set yet - added TODO comments to these as they will need to be adjusted after the tokens are added!

@Shrinks99 Shrinks99 marked this pull request as ready for review January 22, 2026 07:04
@Shrinks99
Copy link
Copy Markdown
Member

Shrinks99 commented Jan 22, 2026

This is a big one! Should be ready to go, component docs still need work, but the elevation properties all seem to be in order! Have also clarified some usage guidelines in the elevation docs page.

Will do a final overview and merge tomorrow.

@Shrinks99 Shrinks99 requested a review from tmccoy14 January 22, 2026 17:12
Copy link
Copy Markdown
Contributor

@tmccoy14 tmccoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - only thing I saw were the errors about declaring variables but never using them

@Shrinks99 Shrinks99 merged commit bf4015f into main Jan 22, 2026
1 check passed
@Shrinks99 Shrinks99 deleted the feature/elevation branch January 22, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants