Merge pull request #1697 from equalizedigital/william/no-issue/make-get_scan_stats-callback-a-named-function-with-explicit-return-type-set-for-static-analysis

Replaced inline permission callback with a named method for get_scan_stats

Author: pattonwebz

includes/classes/class-rest-api.php

@@ -108,14 +108,7 @@ function () use ( $ns, $version ) {
 					[
 						'methods'             => 'GET',
 						'callback'            => [ $this, 'get_scans_stats' ],
-						'permission_callback' => function ( $request ) {
-							if ( Connector::validate_jwt_token_in_request_with_fallback( $request ) ) {
-								// Only allow if the site is still registered (site_id present).
-								$site_id = (string) get_option( 'edac_site_id', '' );
-								return '' !== $site_id;
-							}
-							return current_user_can( 'edit_posts' );
-						},
+						'permission_callback' => [ $this, 'can_get_scans_stats' ],
 					]
 				);
 			}
@@ -365,6 +358,23 @@ function () use ( $ns, $version ) {
 		);
 	}
 
+	/**
+	 * Determine whether the current request may access the scans stats endpoint.
+	 *
+	 * @param \WP_REST_Request $request REST request.
+	 *
+	 * @return bool
+	 */
+	public function can_get_scans_stats( \WP_REST_Request $request ): bool {
+		if ( Connector::validate_jwt_token_in_request_with_fallback( $request ) ) {
+			// Only allow if the site is still registered (site_id present).
+			$site_id = (string) get_option( 'edac_site_id', '' );
+			return '' !== $site_id;
+		}
+
+		return current_user_can( 'edit_posts' );
+	}
+
 	/**
 	 * REST handler to clear issues results for a given post ID.
 	 *