NewWindowWarning: add no-aria-label modifier and disabled flag#1675
Draft
pattonwebz with Copilot wants to merge 2 commits into
Draft
NewWindowWarning: add no-aria-label modifier and disabled flag#1675pattonwebz with Copilot wants to merge 2 commits into
no-aria-label modifier and disabled flag#1675pattonwebz with Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/equalizedigital/accessibility-checker/sessions/70206dc0-474a-4ad8-bb98-f4f9c0cb4f05 Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a helper to block aria-label function in NewWindowWarning
NewWindowWarning: add Apr 28, 2026
no-aria-label modifier and disabled flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The New Window Warning fix had modifier classes to suppress the icon and tooltip independently, but no way to block the aria-label update or disable all NWW behavior entirely for a given container.
New modifier classes
edac-nww-no-aria-label/anww-no-aria-labelSkips
updateAriaLabel()for links within the container. Icon and tooltip still apply normally.edac-nww-disabled/anww-disabledDisables all NWW features (icon, aria-label, tooltip) for links within the container. Links are still marked
data-nww-processedto prevent re-evaluation on subsequent runs (e.g. FacetWP refresh).Both classes follow the existing
anww-*/edac-nww-*dual-prefix convention and apply to bothtarget="_blank"andwindow.openlink types.CSS
The
disabledflag also hides any icons at the CSS level (consistent with the.edac-nww-no-iconpattern) as a safety net.