Release v1.44.0#1781
Conversation
Adds a new axe rule `naked-link` to identify links where the link text is identical to its `href` attribute. This can be a usability issue as URLs are often not human-friendly. The new rule consists of: - A check `link-is-naked` in `src/pageScanner/checks/link-is-naked.js` which performs the core logic of comparing textContent and href. - A rule definition `naked-link` in `src/pageScanner/rules/naked-link.js` which uses the check and defines metadata for the rule. - Registration of the check and rule in `src/pageScanner/config/rules.js`. Additionally, a Jest test suite `tests/jest/rules/naked-link.test.js` has been added to verify the rule's behavior. I encountered issues installing `jest-environment-jsdom` due to network problems, which prevented me from running the tests, but the test code is in place.
TODO: add a proper info_url link
NOTE: I accepted the develop rules.php file. It had changed by a lot so I'll just manually redo it.
Some of these new cases come from the test site where it was decided before what should pass and fail
… complex than initially intended
This will help keep consistent feel as well as making sure we only need to maintain these in one place
…or use across other plugins
…e feature
Removes the specific "Ignore" feature wording from How to Fix descriptions across 11 rule files, replacing it with simplified language ("dismiss this warning in Accessibility Checker") to align with the upcoming UI improvements that rename the ignore/dismiss flow.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Links to https://my.equalizedigital.com/license-keys/ instead of the generic dashboard root so users land directly where their license key lives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…users Replaces the generic "You'll receive weekly accessibility reports" text with a clearer message stating reports go to the license key account owner, and adds a Pro upsell for additional recipients (free users only). Closes #1664 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dden-exclusion fix: exclude wp-block-separator from aria-hidden review warnings
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces version 1.44.0 of the Accessibility Checker plugin, featuring a major refactoring of the issue modal components (such as modularizing the dismiss and fix panels into standalone DismissPanel, FixCard, and CodeMirrorViewer components), exposing shared UI components globally, and improving landmark detection rules. It also enhances accessibility checks, such as bypassing empty paragraph warnings for live regions and validating aria-hidden usage on separator blocks. The code reviewer provided valuable feedback to further improve robustness and accessibility: they recommended resolving an inconsistency in REST API URL generation in class-enqueue-admin.php, enhancing the link accessible name computation in newWindowWarning.js to respect child aria-labels and ignore decorative roles, adding a missing id attribute to TextareaControl in FixCard.js to ensure proper label association, and using token list parsing to check for implicit live region roles in paragraph-not-empty.js to prevent false positives.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Use rest_url( 'accessibility-checker/v1' ) consistently in class-enqueue-admin.php - Respect aria-label on child elements and skip decorative images in newWindowWarning.js traverse() - Add missing id attribute to TextareaControl in FixCard.js for label association - Check implicit live region roles (status, alert, log) in paragraph-not-empty.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Fixed in 266df9e. |
|
✅ Accessibility Checker build (primary only)
|
feat: Add custom axe rule to detect link text is URL
…tentinfo' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lity-checker into release/1.44.0
Updates user-facing strings in the settings page, admin notices, AJAX error messages, site health info, and frontend highlighter to use the current "Dismiss" terminology instead of the legacy "Ignore" wording. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use the noun form "dismissal" instead of the verb "dismiss"/"dismisses" where grammatically required, per Gemini Code Assist review feedback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erminology-in-rule-descriptions-replace-ignore-with PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss'
…tentinfo' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…talls New installs previously defaulted edac_show_metabox_in_block_editor to '0', hiding the metabox out of the box. Both new and existing installs now default to '1' (visible). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ference Ensures add_option() does not overwrite an explicitly set '0' value when the plugin is reactivated — as suggested in the CodeRabbit review on PR #1784. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r-metabox-setting-to-checked-visible-for-new
…block-editor-metabox-setting-to-checked-visible-for-new PRO-1041: Default Block Editor Metabox setting to checked for new installs
Changelog:
Steve Jones (9):
William Patton (9):