PTC accessibility-checker (1985): Automatic Translations June 26, 2026 21:58:35270426#1796
PTC accessibility-checker (1985): Automatic Translations June 26, 2026 21:58:35270426#1796SteveJonesDev wants to merge 33 commits into
Conversation
📝 WalkthroughWalkthroughThe Korean localization string for the Accessibility Checker review prompt was updated, including revised translated text and a changed closing placeholder/tag suffix. ChangesKorean translation update
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Korean translation file for the Accessibility Checker. The reviewer correctly identified that the translation is missing the required %2$s placeholder, which will result in an unclosed HTML tag and break the page's accessibility. A code suggestion was provided to fix this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| #, php-format | ||
| msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" |
There was a problem hiding this comment.
The translation is missing the %2$s placeholder, which is required to output the closing tag. Instead, it contains a corrupted placeholder [/%%p#07527667]. This will cause the tag to remain unclosed in the admin footer, breaking the HTML structure and accessibility of the page. Replacing [/%%p#07527667] with %2$s resolves this issue.
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@languages/accessibility-checker-ko_KR.po`:
- Line 484: The Korean translation for the admin footer text is missing the
required closing %2$s placeholder and currently uses a literal token instead, so
update this msgstr to preserve both placeholders used by Admin_Footer_Text in
class-admin-footer-text.php and restore the closing placeholder exactly where
the link should end. Keep the translated wording, but ensure the placeholder
sequence matches the source string so the footer anchor is closed correctly and
no stray text leaks into the UI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 08b8744c-e121-4f21-a0a9-654131ee4266
📒 Files selected for processing (2)
languages/accessibility-checker-ko_KR.molanguages/accessibility-checker-ko_KR.po
| #, php-format | ||
| msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Restore the %2$s closing placeholder here.
This translation drops the required %2$s placeholder and replaces it with a literal token, so the footer link from admin/class-admin-footer-text.php:38-50 never gets its closing </a>. That will leak garbage text into the UI and can leave the rest of the footer inside the anchor.
🛠️ Proposed fix
-msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!"
+msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" | |
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@languages/accessibility-checker-ko_KR.po` at line 484, The Korean translation
for the admin footer text is missing the required closing %2$s placeholder and
currently uses a literal token instead, so update this msgstr to preserve both
placeholders used by Admin_Footer_Text in class-admin-footer-text.php and
restore the closing placeholder exactly where the link should end. Keep the
translated wording, but ensure the placeholder sequence matches the source
string so the footer anchor is closed correctly and no stray text leaks into the
UI.
Source: Learnings
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d6d18ce12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #, php-format | ||
| msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" |
There was a problem hiding this comment.
In the Korean locale, this php-format translation is passed to sprintf() in Admin_Footer_Text::filter_footer_text() with both the opening and closing anchor; %% renders as a literal percent, so %2$s is never consumed. On Pro-active settings pages the footer output leaves the rating link unclosed and displays the [/%p#07527667] artifact instead of inserting </a>, so the closing placeholder should be restored to %2$s.
Useful? React with 👍 / 👎.
1 participant
This pull request updates translations of resource files that were changed in:
PR #1785 — [Backport] Release v1.44.0 by github-actions[bot]
Merged
release/1.44.0intodevelopChanged monitored files:
languages/accessibility-checker.potView all commits
PR #1726 — Add edac_dismiss_reasons filter to allow customizing dismiss options by SteveJonesDev
Merged
steve/pro-632-feature-allow-dismiss-reasons-to-be-filterable-to-add-orintodevelopChanged monitored files:
languages/accessibility-checker.potView all commits
For the complete list of PTC PRs see the Pull Request History tab.
Summary by CodeRabbit