✨ Add possibility to link to open faq question#1184
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to open FAQ questions via URL hash, enabling deep linking to specific FAQ items. When a user navigates to a URL like /faq#faq-1, the corresponding FAQ question will be displayed in an expanded state on page load.
Key Changes
- Enhanced FAQ question component to detect and respond to URL hash fragments on initial render
- Added test coverage for the initially-open-question scenario
- Updated existing test assertions to use async/await pattern for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/organisms/Faq/Category/Question/Question.tsx |
Implemented hash-based initial expansion logic using useLocation().hash to check if the URL hash matches the FAQ item's ID, with proper animation state handling for initially-open questions |
src/organisms/Faq/Faq.stories.tsx |
Added new test story InitiallyOpenQuestion to verify hash-based opening works correctly, and updated existing test expectations to use async/await pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description
Add possibility for an faq question to start open if the first hash contains its id