💄 Align search and clear icon in Filter search field to vertical center#1185
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Filter component's layout structure to properly align the search icon and clear button to the vertical center of the search field, regardless of content wrapping.
- Introduced a new
SearchAndValuesWrappercomponent to isolate wrapping behavior - Moved
flex-wrap: wrapfromSectiontoSearchAndValuesWrapperto prevent icons from participating in wrapping - Maintained all existing functionality while fixing the vertical alignment issue
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/organisms/Filter/Filter.tsx | Added SearchAndValuesWrapper to wrap chips and search field, isolating wrapping behavior from parent Section |
| src/organisms/Filter/Filter.styles.ts | Created SearchAndValuesWrapper styled component with flex-wrap property moved from Section to properly separate wrapping and non-wrapping layout concerns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description
Aligning search and clear button to vertical center in the Filter component's search field