🐛 Fix dark mode token#1189
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a naming inconsistency in the light mode token definitions. The token --eds_interactive__icon_on_interactive_colors was incorrectly referencing --eds_text__static_icons__default when it should have been referencing the white color token for icons on interactive elements.
- Changed the reference for
--eds_interactive__icon_on_interactive_colorsto point to the correct token - Bumped the package version from 10.5.1 to 10.6.0
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/atoms/style/lightTokens.ts | Updated the token reference for --eds_interactive__icon_on_interactive_colors to use the correct white icon token |
| package.json | Bumped minor version to reflect the token fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Fixing light mode token having wrong definition