Refactor/service now urgency level unable#1194
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
aslakihle
previously approved these changes
Dec 15, 2025
Contributor
aslakihle
left a comment
There was a problem hiding this comment.
Want to bump version, or just let this be part of the next release?
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the urgency level mapping for ServiceNow feedback submissions by downgrading both UNABLE and IMPEDES urgency options to map to ServiceNowUrgency.NORMAL instead of their previous higher severity levels.
Key Changes:
- Modified urgency mapping so that
UrgencyOption.UNABLEreturnsServiceNowUrgency.NORMALinstead ofCRITICAL - Modified urgency mapping so that
UrgencyOption.IMPEDESreturnsServiceNowUrgency.NORMALinstead ofMODERATE - Bumped package version from 10.8.0 to 10.8.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts | Updated getUrgencyNumber function to map both UNABLE and IMPEDES urgency options to NORMAL severity level |
| package.json | Incremented patch version to 10.8.1 to reflect the urgency mapping changes |
Comments suppressed due to low confidence (1)
src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts:54
- The getUrgencyNumber function lacks test coverage. Since the test file Feedback.utils.test.ts already contains tests for other utility functions like getSeverityEmoji, consider adding tests to verify the urgency mapping behavior, especially given this change in mapping logic.
export const getUrgencyNumber = (urgency: UrgencyOption) => {
switch (urgency) {
case UrgencyOption.UNABLE:
return ServiceNowUrgency.NORMAL;
case UrgencyOption.IMPEDES:
return ServiceNowUrgency.NORMAL;
case UrgencyOption.NO_IMPACT:
return ServiceNowUrgency.NORMAL;
}
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aslakihle
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to how urgency levels are mapped in the
readUploadedFileAsTextutility. Now, bothUNABLEandIMPEDESurgency options are mapped toServiceNowUrgency.NORMALinstead ofCRITICALandMODERATE, respectively.getUrgencyNumberso that bothUrgencyOption.UNABLEandUrgencyOption.IMPEDESnow returnServiceNowUrgency.NORMALinstead of their previous higher urgency levels. (src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts)