Fix/hide-singleselect-clear-on-disabled#1195
Conversation
There was a problem hiding this comment.
Pull request overview
The changes include adding a disabled state test for SingleSelect and preventing the clear button from showing when the component is disabled.
Key changes:
- Updated clear button visibility logic to hide it when the component is disabled
- Added a new test story
DisabledSingleSelectto verify the disabled state
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/molecules/Select/SingleSelect/SingleSelect.stories.tsx | Adds imports for StoryObj and expect, and creates a new DisabledSingleSelect story with a play function to test disabled behavior |
| src/molecules/Select/SearchBar.tsx | Adds aria-disabled attribute to the Container element and updates the clear button conditional to respect disabled state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
benjamin-lyon
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Azure DevOps links
User story
Description