🐛 Fix banner compact padding#1196
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the padding for the compact banner variant by adjusting it to use different vertical and horizontal spacing values instead of uniform spacing on all sides.
- Changed compact banner padding from uniform
spacings.smallto${spacings.x_small} ${spacings.small}(vertical horizontal) - Updated mockServiceWorker.js to version 2.12.7
- Updated various dependencies in bun.lock
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/molecules/Banner/Banner.styles.ts | Modified compact banner padding to use x_small for vertical and small for horizontal spacing |
| public/mockServiceWorker.js | Version bump from 2.12.4 to 2.12.7 |
| bun.lock | Dependency updates for various packages including React Aria, Storybook, TypeScript ESLint, and others |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aslakihle
approved these changes
Jan 5, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description
Adjusting padding for compact banner