Fix/rename js calendar to atwork#1199
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the "js calendar"/"jscalendar" application icon to "atwork" across the codebase. The change is comprehensive, updating all references in component files, tests, and stories.
Key Changes:
- Renamed component from
JsCalendartoAtWorkwith corresponding file rename - Updated icon data export from
jscalendartoatwork - Updated all import statements, type definitions, and test references
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/molecules/ApplicationIcon/Icons/Atwork.tsx |
Renamed component from JsCalendar to AtWork, updated import from jscalendar to atwork, reformatted component declaration |
src/molecules/ApplicationIcon/ApplicationIconCollection.tsx |
Renamed icon data export from jscalendar to atwork |
src/molecules/ApplicationIcon/ApplicationIcon.tsx |
Updated import statement, type definition, and app configuration to use new AtWork component and atwork name |
src/molecules/ApplicationIcon/ApplicationIcon.test.tsx |
Updated import and test data references from jscalendar to atwork |
src/molecules/ApplicationIcon/ApplicationIcon.stories.tsx |
Updated story options from jscalendar to atwork |
Comments suppressed due to low confidence (1)
src/molecules/ApplicationIcon/Icons/Atwork.tsx:26
- The displayName should match the component name 'AtWork' for consistency. Currently it's set to 'atWork' (lowercase 'a') while the component is named 'AtWork' (uppercase 'A'). This inconsistency can cause confusion during debugging and when using React DevTools.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
There are some recent changes in the application icon component, so you need to fix the conflicts 👁️ 👁️ |
mariush2
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/molecules/ApplicationIcon/Icons/Atwork.tsx:26
- The displayName should match the component name exactly. Based on the pattern used in other icon components (e.g., Sam.displayName = 'Sam', JsEmbark.displayName = 'JsEmbark', FourDInsight.displayName = 'FourDInsight'), this should be 'AtWork' instead of 'atWork'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description
Change name js calendar to atwork.