Skip to content

feat: Added 'maxCharacters' prop to TextField#1200

Merged
mariush2 merged 12 commits into
mainfrom
feat/textfield-helperRight
Jan 12, 2026
Merged

feat: Added 'maxCharacters' prop to TextField#1200
mariush2 merged 12 commits into
mainfrom
feat/textfield-helperRight

Conversation

@mariush2

@mariush2 mariush2 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Azure DevOps links

User story


  • Needs to be tested locally by reviewer

Description

Adding new maxCharacters prop to Textfield, this will always have the tertiary color (for now)

Copilot AI review requested due to automatic review settings January 8, 2026 08:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new helperTextRight prop to the TextField component that displays helper text aligned to the right side of the field. The text is styled with tertiary color and positioned absolutely to align with the existing left-aligned helper text.

Key changes:

  • Added helperTextRight optional prop to TextFieldProps
  • Implemented dynamic width measurement and margin adjustment to prevent overlap between left and right helper texts
  • Added Storybook story and documentation for the new feature

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/molecules/TextField/TextField.tsx Added helperTextRight prop, state management for width calculation, styled component for right-aligned helper text, and conditional rendering logic
src/molecules/TextField/TextField.stories.tsx Added argType control for the new prop and a story with interaction test to demonstrate the feature
src/molecules/TextField/TextField.docs.mdx Added documentation section showcasing the HelperTextRight story

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.stories.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.stories.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 16674 / 16674
🔵 Statements 100% (🎯 100%) 16674 / 16674
🔵 Functions 100% (🎯 100%) 1207 / 1207
🔵 Branches 100% (🎯 100%) 4164 / 4164
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/TextField/TextField.tsx 100% 100% 100% 100%
Generated in workflow #2053 for commit be9646f by the Vitest Coverage Report Action

Copilot AI review requested due to automatic review settings January 9, 2026 07:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.stories.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx Outdated
Copilot AI review requested due to automatic review settings January 9, 2026 07:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
@mariush2 mariush2 changed the title feat: Added 'helperTextRight' prop to TextField feat: Added 'maxCharacters' prop to TextField Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 10:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Copilot AI review requested due to automatic review settings January 12, 2026 07:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.jsdom.test.tsx
Comment thread src/molecules/TextField/TextField.tsx
Comment thread src/molecules/TextField/TextField.tsx
@mariush2 mariush2 marked this pull request as ready for review January 12, 2026 07:34
@mariush2 mariush2 requested a review from a team as a code owner January 12, 2026 07:34
@mariush2 mariush2 requested a review from aslakihle January 12, 2026 07:34

@aslakihle aslakihle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@mariush2 mariush2 merged commit 513bbd9 into main Jan 12, 2026
8 of 9 checks passed
@mariush2 mariush2 deleted the feat/textfield-helperRight branch January 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants