Fix/faq-search-relative-navigation#1201
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the FAQ search navigation by removing an unnecessary from parameter constraint from the useNavigate hook, allowing the component to work correctly with relative navigation regardless of the current route.
- Removed
from: '/faq'parameter fromuseNavigate()hook in Search component - Bumped package version from 10.8.2 to 10.8.3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/organisms/Faq/Search.tsx | Removed the from: '/faq' constraint from useNavigate to allow relative navigation from any route |
| package.json | Bumped patch version to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
There is some stuff in dev that I don't want to release just yet (Vilde is gonna look at it tomorrow morning). Are you OK with me merging this PR when that is done? |
No problemo 👍 |
Description
Makes FAQ search navigation relative. Previously, it assumed the base path of
/faq, but some applications may render the FAQ component on other routes.