Skip to content

Fix/faq-search-relative-navigation#1201

Merged
benjamin-lyon merged 2 commits into
mainfrom
fix/faq-search-relative-navigation
Jan 8, 2026
Merged

Fix/faq-search-relative-navigation#1201
benjamin-lyon merged 2 commits into
mainfrom
fix/faq-search-relative-navigation

Conversation

@benjamin-lyon

@benjamin-lyon benjamin-lyon commented Jan 8, 2026

Copy link
Copy Markdown
Contributor
  • Needs to be tested locally by reviewer

Description

Makes FAQ search navigation relative. Previously, it assumed the base path of /faq, but some applications may render the FAQ component on other routes.

Copilot AI review requested due to automatic review settings January 8, 2026 11:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the FAQ search navigation by removing an unnecessary from parameter constraint from the useNavigate hook, allowing the component to work correctly with relative navigation regardless of the current route.

  • Removed from: '/faq' parameter from useNavigate() hook in Search component
  • Bumped package version from 10.8.2 to 10.8.3

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/organisms/Faq/Search.tsx Removed the from: '/faq' constraint from useNavigate to allow relative navigation from any route
package.json Bumped patch version to reflect the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benjamin-lyon benjamin-lyon marked this pull request as ready for review January 8, 2026 11:25
@benjamin-lyon benjamin-lyon requested a review from a team as a code owner January 8, 2026 11:25
@benjamin-lyon benjamin-lyon requested a review from mariush2 January 8, 2026 11:25
@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 16608 / 16608
🔵 Statements 100% (🎯 100%) 16608 / 16608
🔵 Functions 100% (🎯 100%) 1200 / 1200
🔵 Branches 100% (🎯 100%) 4132 / 4132
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/organisms/Faq/Search.tsx 100% 100% 100% 100%
Generated in workflow #2038 for commit 825616a by the Vitest Coverage Report Action

@mariush2

mariush2 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

There is some stuff in dev that I don't want to release just yet (Vilde is gonna look at it tomorrow morning). Are you OK with me merging this PR when that is done?

@benjamin-lyon

Copy link
Copy Markdown
Contributor Author

There is some stuff in dev that I don't want to release just yet (Vilde is gonna look at it tomorrow morning). Are you OK with me merging this PR when that is done?

No problemo 👍

@benjamin-lyon benjamin-lyon merged commit 7931379 into main Jan 8, 2026
17 checks passed
@benjamin-lyon benjamin-lyon deleted the fix/faq-search-relative-navigation branch January 8, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants