Skip to content

fix: TextField margin bottom#1207

Merged
mariush2 merged 2 commits into
mainfrom
fix/max-characters-margin
Jan 15, 2026
Merged

fix: TextField margin bottom#1207
mariush2 merged 2 commits into
mainfrom
fix/max-characters-margin

Conversation

@mariush2
Copy link
Copy Markdown
Contributor


  • Needs to be tested locally by reviewer

Description

There was a margin bottom on text fields when there isn't a helperText, this should only be there if maxCharacters is defined as well

Copilot AI review requested due to automatic review settings January 14, 2026 12:29
@mariush2 mariush2 requested a review from a team as a code owner January 14, 2026 12:29
@mariush2 mariush2 requested a review from aslakihle January 14, 2026 12:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue with unnecessary margin bottom being applied to TextField components. Previously, margin was applied whenever there was no helper text, but it should only be applied when there's no helper text AND a maxCharacters count is displayed.

Changes:

  • Updated marginBottom logic to only apply spacing when both !helperText and maxCharacters are present
  • Bumped package version from 10.9.1 to 10.9.2

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/molecules/TextField/TextField.tsx Fixed conditional logic for marginBottom to only apply when maxCharacters is defined and no helperText exists
package.json Version bump for the fix release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 99.98% (🎯 100%) 16690 / 16692
🔵 Statements 99.98% (🎯 100%) 16690 / 16692
🔵 Functions 99.91% (🎯 100%) 1208 / 1209
🔵 Branches 100% (🎯 100%) 4170 / 4170
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/TextField/TextField.tsx 100% 100% 100% 100%
Generated in workflow #2068 for commit aeb38d8 by the Vitest Coverage Report Action

@mariush2 mariush2 merged commit 6adfe59 into main Jan 15, 2026
16 of 17 checks passed
@mariush2 mariush2 deleted the fix/max-characters-margin branch January 15, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants