feat: Tabs variants and trailingIcon#1210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds variant (error/warning) and trailingIcon support to the Tabs component, along with improved hover styling for inactive tabs.
Changes:
- Added
variantandtrailingIconproperties to the Tab interface - Implemented variant icon rendering with precedence over leadingIcon
- Updated hover state styling to change text color for inactive tabs
- Added Storybook stories with play functions to demonstrate new features
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/molecules/Tabs/Tabs.types.ts | Adds variant and trailingIcon properties to the Tab interface |
| src/molecules/Tabs/Tab.tsx | Implements variant icon logic, trailingIcon rendering, and variant-specific icon colors |
| src/molecules/Tabs/Tab.styles.ts | Updates hover styling to change label color for inactive tabs |
| src/molecules/Tabs/Tabs.stories.tsx | Adds new stories for WithTrailingIcon and Variants features with test coverage |
| .gitignore | Consolidates Webstorm settings and adds vcs.xml to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description