feat: Survey dialog#1264
Merged
Merged
Conversation
# Conflicts: # .idea/vcs.xml # bun.lock # src/molecules/Dialog/Dialog.styles.ts # src/molecules/OptionalTooltip/OptionalTooltip.test.tsx
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new SurveyProvider + dialog UI for rendering and answering active surveys, and updates Storybook/router utilities and a few supporting components to align with newer conventions and dependencies.
Changes:
- Added a new Survey feature area (
SurveyProvider, dialog, question components, Storybook stories/play tests). - Updated Storybook router parameter shape (
initialEntries→initial) across many stories and added Storybook typings. - Bumped
motionand adjusted related mocks/types; tightened lint to includetsc --noEmit.
Reviewed changes
Copilot reviewed 47 out of 50 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/framerMotionMock.ts | Adjusts MotionValue import to match updated motion package structure. |
| src/storybook/PropsTable.tsx | Removes PropTypes usage from Storybook helper component. |
| src/providers/TutorialHighlightingProvider/TutorialPopover/hooks/useTutorialPopoverPosition.ts | Adds explicit typing for useTransform callback arg. |
| src/providers/TutorialHighlightingProvider/TutorialPopover/hooks/useTutorialPopoverPosition.test.tsx | Updates hook tests to include newly required contentRef argument. |
| src/providers/TutorialHighlightingProvider/TutorialHighlightingProvider.stories.tsx | Migrates Storybook router params to new initial field. |
| src/providers/TutorialHighlightingProvider/hooks/useReversedScrollY.ts | Adds explicit typing for useTransform callback arg. |
| src/providers/SurveyProvider/SurveyProvider.types.ts | Introduces local question type helpers for survey rendering. |
| src/providers/SurveyProvider/SurveyProvider.tsx | Adds Survey context/provider with active survey state and answer/opt-out handling. |
| src/providers/SurveyProvider/SurveyProvider.stories.tsx | Adds Storybook stories and play tests for survey flows (standard + UMUX). |
| src/providers/SurveyProvider/SurveyDialog/UmuxDialog.tsx | Implements UMUX-specific dialog flow (answer all questions, complete). |
| src/providers/SurveyProvider/SurveyDialog/SurveyQuestion/SurveyQuestion.tsx | Routes question rendering by QuestionType. |
| src/providers/SurveyProvider/SurveyDialog/SurveyQuestion/SurveyMultipleChoiceQuestion.tsx | Implements multiple-choice question UI bound to provider state. |
| src/providers/SurveyProvider/SurveyDialog/SurveyQuestion/SurveyLinearScaleQuestion.tsx | Implements linear scale question UI (also reused for UMUX). |
| src/providers/SurveyProvider/SurveyDialog/SurveyQuestion/SurveyFreeTextQuestion.tsx | Implements free-text question UI bound to provider state. |
| src/providers/SurveyProvider/SurveyDialog/SurveyProgress.tsx | Adds progress/percentage UI for survey dialog. |
| src/providers/SurveyProvider/SurveyDialog/SurveyDialog.tsx | Adds main dialog flow for non-UMUX surveys and switches to UMUX dialog when needed. |
| src/providers/SurveyProvider/SurveyDialog/SurveyDialog.styles.ts | Adds shared styling wrapper for dialog content. |
| src/providers/SurveyProvider/hooks/useSurvey.ts | Adds hook for consuming SurveyContext. |
| src/organisms/TopBar/Tutorials/Tutorials.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/TopBar/TopBar.stories.tsx | Migrates Storybook router params; removes console logging in story props. |
| src/organisms/TopBar/Resources/Resources.tsx | Removes unused field prop plumbing into Feedback. |
| src/organisms/TopBar/Resources/Resources.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/TopBar/Guidelines/Guidelines.test.tsx | Fixes test data shape for colorBox boolean flag. |
| src/organisms/TopBar/FieldMenu/FieldMenu.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/TopBar/Account/StatusAvatar.tsx | Makes variant required in StatusAvatarProps. |
| src/organisms/TableOfContents/TableOfContents.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/ServerError.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/PageNotFound.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/MissingPermissions.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/GenericError.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/BadRequest.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Status/collections/ApiResponseError.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/SideBar/SideBar.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/ReleaseNotesPage/ReleaseNotesPage.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/ReleaseNotesPage/ReleaseNoteFilter.tsx | Fixes clearing filter when search[key] is undefined. |
| src/organisms/FieldSelector/FieldSelector.stories.tsx | Migrates Storybook router params to new initial field. |
| src/organisms/Faq/Faq.stories.tsx | Migrates Storybook router params to new initial field. |
| src/molecules/Waves/Waves.stories.tsx | Migrates Storybook router params to new initial field. |
| src/molecules/Typography/Typography.stories.tsx | Refactors story layout to use in-story wrapper rather than decorators. |
| src/molecules/Stepper/Stepper.stories.tsx | Migrates Storybook router params to new initial field. |
| src/molecules/RichTextEditor/MenuBar/TextColor.tsx | Switches color input handler from onInput to onChange. |
| src/molecules/RichTextDisplay/RichTextDisplay.tsx | Formats props interface declaration (no behavioral change). |
| src/molecules/RichTextDisplay/RichTextDisplay.stories.tsx | Avoids passing Storybook’s internal _children arg into component props; simplifies render fn. |
| src/molecules/IconCell/stories/data.ts | Updates IconCell story data enums/colors to new values. |
| src/atoms/style/spacings.stories.tsx | Updates Storybook meta to use render instead of component. |
| package.json | Updates lint to run typecheck; bumps motion dependency. |
| bun.lock | Lockfile update for motion bump. |
| .storybook/storybook.d.ts | Adds Storybook parameters typing for msw/router/design. |
| .storybook/preview.tsx | Updates router decorator to new initial API; refactors provider decorator; adjusts mocked AuthProvider import path. |
| .idea/conventionalCommit.xml | Adds IDE config related to conventional commits. |
Files not reviewed (1)
- .idea/conventionalCommit.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 47 out of 50 changed files in this pull request and generated 12 comments.
Files not reviewed (1)
- .idea/conventionalCommit.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 64 out of 68 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- .idea/conventionalCommit.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 64 out of 68 changed files in this pull request and generated 9 comments.
Files not reviewed (1)
- .idea/conventionalCommit.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 64 out of 68 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- .idea/conventionalCommit.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
Feature
User story
Description
This PR adds the survey provider