Skip to content

style: Set unit text color#1274

Merged
arkadiy93 merged 3 commits into
mainfrom
fix/TextfieldAdjustments
Apr 28, 2026
Merged

style: Set unit text color#1274
arkadiy93 merged 3 commits into
mainfrom
fix/TextfieldAdjustments

Conversation

@arkadiy93
Copy link
Copy Markdown
Contributor

Azure DevOps links

User story

Notes

  • This PR doesn't set color on clear button as the button does not exist. Adding it might be a bit complicated as the component is based on EDS component.

Copilot AI review requested due to automatic review settings April 27, 2026 12:39
@arkadiy93 arkadiy93 changed the title 💄 Set unit text color style: Set unit text color Apr 27, 2026
@arkadiy93 arkadiy93 marked this pull request as ready for review April 27, 2026 12:40
@arkadiy93 arkadiy93 requested a review from a team as a code owner April 27, 2026 12:40
@arkadiy93 arkadiy93 requested a review from mariush2 April 27, 2026 12:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TextField molecule styling so the unit/adornment text matches the intended (tertiary) text color tokens when rendered via EDS.

Changes:

  • Add a styled-components rule to set the color of the unit/adornment text within the EDS TextField adornments container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/molecules/TextField/TextField.tsx Outdated
Comment thread src/molecules/TextField/TextField.tsx Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 17258 / 17258
🔵 Statements 100% (🎯 100%) 17258 / 17258
🔵 Functions 100% (🎯 100%) 1242 / 1242
🔵 Branches 100% (🎯 100%) 4373 / 4373
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/TextField/TextField.tsx 100% 100% 100% 100%
Generated in workflow #2250 for commit f7212c6 by the Vitest Coverage Report Action

mariush2
mariush2 previously approved these changes Apr 28, 2026
Copilot AI review requested due to automatic review settings April 28, 2026 08:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +78 to +84
${({ $disabled }) =>
!$disabled &&
css`
div[class*='Input__Adornments'] > span {
color: ${colors.text.static_icons__tertiary.rgba};
}
`}
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new unit/adornment color override isn’t covered by the existing TextField styling tests. Consider adding a jsdom test that renders a TextField with unit and asserts the rendered unit/adornment text has colors.text.static_icons__tertiary.rgba when enabled (and optionally that it does not override disabled/loading styling).

Copilot uses AI. Check for mistakes.
@arkadiy93 arkadiy93 merged commit aa5bec0 into main Apr 28, 2026
15 checks passed
@arkadiy93 arkadiy93 deleted the fix/TextfieldAdjustments branch April 28, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants