feat: allow string values for table of contents count prop#1280
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR widens the typing for “count/value” fields so consumers can pass either numeric counts or pre-formatted string counts (e.g., "9+") when rendering badges in Tabs and Table of Contents.
Changes:
- Allow
TableOfContentsItemType.countto benumber | string. - Allow
Tab<T>.countto benumber | string. - Allow
BadgeProps.valueto benumber | string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/providers/TableOfContentsProvider.tsx | Widened TableOfContentsItemType.count typing to accept strings for formatted counts. |
| src/molecules/Tabs/Tabs.types.ts | Widened Tab<T>.count typing to accept strings, aligning with badge/count rendering usage. |
| src/molecules/Badge/Badge.tsx | Widened BadgeProps.value typing to accept strings, enabling formatted badge content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
mariush2
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description