Skip to content

fix: make button inline#1287

Merged
arkadiy93 merged 2 commits into
mainfrom
fix/makeButtonInline
May 27, 2026
Merged

fix: make button inline#1287
arkadiy93 merged 2 commits into
mainfrom
fix/makeButtonInline

Conversation

@arkadiy93
Copy link
Copy Markdown
Contributor

@arkadiy93 arkadiy93 commented May 27, 2026

  • Changed the CSS display property of ButtonPrimitive from grid to inline-grid in Button.styles.ts to improve button layout behavior.

Copilot AI review requested due to automatic review settings May 27, 2026 10:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Button styling so it behaves as an inline element (without forcing a full-line block layout), and bumps the package version to publish the fix.

Changes:

  • Update ButtonPrimitive to use display: inline-grid instead of grid.
  • Bump library version from 13.1.0 to 13.1.1.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/molecules/Button/Button.styles.ts Makes the button render inline (via inline-grid) while retaining the grid-based internal layout.
package.json Patch version bump for releasing the styling fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arkadiy93 arkadiy93 marked this pull request as ready for review May 27, 2026 11:00
@arkadiy93 arkadiy93 requested a review from a team as a code owner May 27, 2026 11:00
@arkadiy93 arkadiy93 requested a review from aslakihle May 27, 2026 11:00
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 17399 / 17399
🔵 Statements 100% (🎯 100%) 17399 / 17399
🔵 Functions 100% (🎯 100%) 1278 / 1278
🔵 Branches 100% (🎯 100%) 4445 / 4445
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/Button/Button.styles.ts 100% 100% 100% 100%
Generated in workflow #2316 for commit fe83bf4 by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@aslakihle aslakihle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@arkadiy93 arkadiy93 merged commit 2276f65 into main May 27, 2026
12 checks passed
@arkadiy93 arkadiy93 deleted the fix/makeButtonInline branch May 27, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants